From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9tLA-0002Ap-5S for qemu-devel@nongnu.org; Wed, 23 Jul 2014 06:00:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9tL4-0005jI-8V for qemu-devel@nongnu.org; Wed, 23 Jul 2014 06:00:04 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:65003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9tL4-0005j6-26 for qemu-devel@nongnu.org; Wed, 23 Jul 2014 05:59:58 -0400 Received: by mail-wg0-f43.google.com with SMTP id l18so906825wgh.14 for ; Wed, 23 Jul 2014 02:59:54 -0700 (PDT) Message-ID: <53CF877F.8070500@linaro.org> Date: Wed, 23 Jul 2014 11:59:27 +0200 From: Eric Auger MIME-Version: 1.0 References: <1404736043-22900-1-git-send-email-eric.auger@linaro.org> <1404736043-22900-4-git-send-email-eric.auger@linaro.org> <1404845752.4256.119.camel@ul30vt.home> In-Reply-To: <1404845752.4256.119.camel@ul30vt.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 03/13] hw/vfio/pci: Remove unneeded include files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: agraf@suse.de, kim.phillips@freescale.com, eric.auger@st.com, peter.maydell@linaro.org, patches@linaro.org, will.deacon@arm.com, qemu-devel@nongnu.org, a.rigo@virtualopensystems.com, Bharat.Bhushan@freescale.com, stuart.yoder@freescale.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org On 07/08/2014 08:55 PM, Alex Williamson wrote: > On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: >> Signed-off-by: Eric Auger >> --- >> hw/vfio/pci.c | 12 ------------ >> 1 file changed, 12 deletions(-) >> >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index 5c7bfd5..a7df3de 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -18,26 +18,14 @@ >> * Copyright (C) 2008, IBM, Muli Ben-Yehuda (muli@il.ibm.com) >> */ >> >> -#include >> #include >> #include >> #include >> -#include >> -#include >> -#include >> - >> -#include "config.h" >> #include "exec/address-spaces.h" >> -#include "exec/memory.h" >> #include "hw/pci/msi.h" >> #include "hw/pci/msix.h" >> -#include "hw/pci/pci.h" >> -#include "qemu-common.h" >> #include "qemu/error-report.h" >> -#include "qemu/event_notifier.h" >> -#include "qemu/queue.h" >> #include "qemu/range.h" >> -#include "sysemu/kvm.h" >> #include "sysemu/sysemu.h" >> #include "hw/vfio/vfio.h" > > Was this just a remove and see if it still compiles exercise? I'm not > sure I'm a fan of removing includes that are arbitrarily included via > another include chain. Thanks, Hi Alex. Sorry for the delay, coming back from vacation period... Yes it was a lazy way to sort things out for PCI/platform split. Then I will drop that patch file. Besides, some system includes might be removed thanks to the inclusion of qemu-common.h, which sounds stable/reliable? dirent.h as well? Anyway it does not help in any way for my matters. Best Regards Eric > > Alex >