From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55305)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1X9uvG-0002x6-Ag
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 07:41:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1X9uvA-0004HR-6s
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 07:41:26 -0400
Received: from mail-we0-f171.google.com ([74.125.82.171]:41506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1X9uvA-0004HN-0e
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 07:41:20 -0400
Received: by mail-we0-f171.google.com with SMTP id p10so1040824wes.16
	for <qemu-devel@nongnu.org>; Wed, 23 Jul 2014 04:41:16 -0700 (PDT)
Message-ID: <53CF9F41.5080808@linaro.org>
Date: Wed, 23 Jul 2014 13:40:49 +0200
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <1404736043-22900-1-git-send-email-eric.auger@linaro.org>
	<1404736043-22900-5-git-send-email-eric.auger@linaro.org>
	<1404859290.4256.152.camel@ul30vt.home>
	<53CF883C.5000504@linaro.org>
	<CAFEAcA9ahoyUKzgMbsEM15siAmNm8wiDOeXw2r+52VgU7jPB7g@mail.gmail.com>
In-Reply-To: <CAFEAcA9ahoyUKzgMbsEM15siAmNm8wiDOeXw2r+52VgU7jPB7g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 04/13] hw/vfio/pci: introduce VFIODevice
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, Kim Phillips <kim.phillips@freescale.com>, eric.auger@st.com, Patch Tracking <patches@linaro.org>, Will Deacon <will.deacon@arm.com>, QEMU Developers <qemu-devel@nongnu.org>, Alvise Rigo <a.rigo@virtualopensystems.com>, Bharat Bhushan <Bharat.Bhushan@freescale.com>, Alex Williamson <alex.williamson@redhat.com>, Stuart Yoder <stuart.yoder@freescale.com>, Antonios Motakis <a.motakis@virtualopensystems.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On 07/23/2014 12:24 PM, Peter Maydell wrote:
> On 23 July 2014 11:02, Eric Auger <eric.auger@linaro.org> wrote:
>> On 07/09/2014 12:41 AM, Alex Williamson wrote:
>>> On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote:
>>>> +    vdev->vbasedev.ops = &vfio_pci_ops;
>>>> +
>>>> +    vdev->vbasedev.type = VFIO_DEVICE_TYPE_PCI;
>>>> +    vdev->vbasedev.name = g_malloc0(PATH_MAX);
>>>> +    snprintf(vdev->vbasedev.name, PATH_MAX, "%04x:%02x:%02x.%01x",
>>>> +            vdev->host.domain, vdev->host.bus, vdev->host.slot,
>>>> +            vdev->host.function);
>>>> +
>>>
>>> asprintf(3)?  This is a deterministic length, so PATH_MAX is especially
>>> ridiculous.
>> agreed, will use asprintf instead.
> 
> A minor nit given this is going to be in "only on Linux"
> code, but we generally prefer g_strdup_printf() over
> raw asprintf() (they do the same thing, but the glib
> function is guaranteed to be present everywhere,
> and the returned memory is freeable with g_free()
> like most of our strings, rather than needing to remember
> that it needs to be freed via free().)

Hi Peter,

thanks. this is noted.

BR

Eric
> 
> thanks
> -- PMM
>