From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9v5B-0005pU-L3 for qemu-devel@nongnu.org; Wed, 23 Jul 2014 07:51:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9v56-0007VE-Ll for qemu-devel@nongnu.org; Wed, 23 Jul 2014 07:51:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9v56-0007V6-CT for qemu-devel@nongnu.org; Wed, 23 Jul 2014 07:51:36 -0400 Message-ID: <53CFA1C4.2010805@redhat.com> Date: Wed, 23 Jul 2014 05:51:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406062892-4982-1-git-send-email-eblake@redhat.com> <871ttcfse0.fsf@blackfin.pond.sub.org> In-Reply-To: <871ttcfse0.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uDEb8Adns4tmGeKpBmDpgfhiBsXPIB6vw" Subject: Re: [Qemu-devel] [PATCH for-2.1] docs: document remaining QMP events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uDEb8Adns4tmGeKpBmDpgfhiBsXPIB6vw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2014 01:25 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Commit dfab4892 restored this file, but did not address any of the >> grammar problems that had been fixed in passing when moving events >> out of this file. There are also a couple events that were >> undocumented since introduction, and one that had been added only >> in the time that this file was temporarily deleted. >> -SPICE_CONNECTED, SPICE_DISCONNECTED >> ------------------------------------ >> +SPICE_CONNECTED >> +--------------- >> >> -Emitted when a SPICE client connects or disconnects. >> +Emitted when a SPICE client connects. >=20 > Wording doesn't match qapi-event.json exactly. I doubt we care. Not the only place where they don't match. And I personally don't care := ) >> >> +SPICE_INITIALIZED >=20 > Another SPICE_INITIALIZED? Do you mean SPICE_MIGRATE_COMPLETED? >=20 Copy-and-paste strikes again. Yes, I'll fix that. >=20 > Assuming you do mean SPICE_MIGRATE_COMPLETED: list is complete now. >=20 > Would you mind splitting this patch? >=20 > * Either one patch per undocumented event (if you want to be nice to > downstreams cherry-picking events), or one patch for all of them. >=20 > * One patch for the rest. Or if you feel generous, two: one for the > grammar fixes, one for the spice split. v2 coming up as a full series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uDEb8Adns4tmGeKpBmDpgfhiBsXPIB6vw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTz6HEAAoJEKeha0olJ0Nq4RsIAJxxfibixuGDAu4IteFDo7RG oqb4uodZiJT29yO7YgQmD6cKGKizNd+I9H/fWU0t1MDHAGztv4WvV+8V00slFgHU JzZncfsHbljpKISIMSgWqUjpCI1ec66+ExSLjfZTMibkkFBwLygEc4GcsTcRQOH5 GEr/sNpK3GPTxG74m3CV0QS6I7SGKqb4DkrzORqBI/gvj5QyIt3mAYc8E21MHUiB 9i1YF9lQqjBeadxhamhbl2WM3YBRz7NUoXFQPKcTv4aeDVWHqSBz+WoXI/dsSt36 qMXGuOIOcaniqSTcomR3VMAw3JWpkMntal4kIAY7moNKFdtnvl4N+ZzzXkrqTuk= =klQa -----END PGP SIGNATURE----- --uDEb8Adns4tmGeKpBmDpgfhiBsXPIB6vw--