From: Wenchao Xia <wenchaoqemu@gmail.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.1 4/5] docs: document missing POWERDOWN event
Date: Wed, 23 Jul 2014 22:11:33 +0800 [thread overview]
Message-ID: <53CFC295.3020007@gmail.com> (raw)
In-Reply-To: <1406118378-11217-5-git-send-email-eblake@redhat.com>
于 2014/7/23 20:26, Eric Blake 写道:
> The POWERDOWN event was first documented in 0aab9ec3. But since
> dfab4892 later restored this file to the state prior to qmp events,
> and we never documented it in the past, anyone using this file
> instead of qapi will miss out on this event. Tweak the existing
> wording of SHUTDOWN to match 84321831, and make the difference
> between the two events apparent.
>
> * docs/qmp/qmp-events.txt (POWERDOWN): Add.
> (SHUTDOWN): Tweak.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> docs/qmp/qmp-events.txt | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> index 22d552f..9d7439e 100644
> --- a/docs/qmp/qmp-events.txt
> +++ b/docs/qmp/qmp-events.txt
> @@ -243,6 +243,19 @@ Data:
> "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
> }
>
> +POWERDOWN
> +---------
> +
> +Emitted when the Virtual Machine is powered down through the power
> +control system, such as via ACPI.
> +
> +Data: None.
> +
> +Example:
> +
> +{ "event": "POWERDOWN",
> + "timestamp": { "seconds": 1267040730, "microseconds": 682951 } }
> +
> QUORUM_FAILURE
> --------------
>
> @@ -325,7 +338,8 @@ Example:
> SHUTDOWN
> --------
>
> -Emitted when the Virtual Machine is powered down.
> +Emitted when the Virtual Machine has shut down, indicating that qemu
> +is about to exit.
>
> Data: None.
>
Nice to have explantion about the difference.
next prev parent reply other threads:[~2014-07-23 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:26 [Qemu-devel] [PATCH v2 for-2.1 0/5] docs: document remaining QMP events Eric Blake
2014-07-23 12:26 ` [Qemu-devel] [PATCH v2 for-2.1 1/5] docs: grammar fixes to qmp-events Eric Blake
2014-07-23 12:26 ` [Qemu-devel] [PATCH v2 for-2.1 2/5] docs: split SPICE_* event docs Eric Blake
2014-07-23 12:26 ` [Qemu-devel] [PATCH v2 for-2.1 3/5] docs: document missing SPICE_MIGRATE_COMPLETED event Eric Blake
2014-07-23 13:43 ` Markus Armbruster
2014-07-23 12:26 ` [Qemu-devel] [PATCH v2 for-2.1 4/5] docs: document missing POWERDOWN event Eric Blake
2014-07-23 14:11 ` Wenchao Xia [this message]
2014-07-23 12:26 ` [Qemu-devel] [PATCH v2 for-2.1 5/5] docs: document missing VSERPORT_CHANGE event Eric Blake
2014-07-23 13:44 ` [Qemu-devel] [PATCH v2 for-2.1 0/5] docs: document remaining QMP events Markus Armbruster
2014-07-23 14:12 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFC295.3020007@gmail.com \
--to=wenchaoqemu@gmail.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).