From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1X9xGx-0006uA-0k
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:12:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1X9xGn-0007iZ-OC
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:11:58 -0400
Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:54614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1X9xGn-0007fg-Ho
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:11:49 -0400
Received: by mail-pa0-f45.google.com with SMTP id eu11so1806965pac.32
	for <qemu-devel@nongnu.org>; Wed, 23 Jul 2014 07:11:48 -0700 (PDT)
Message-ID: <53CFC295.3020007@gmail.com>
Date: Wed, 23 Jul 2014 22:11:33 +0800
From: Wenchao Xia <wenchaoqemu@gmail.com>
MIME-Version: 1.0
References: <1406118378-11217-1-git-send-email-eblake@redhat.com>
	<1406118378-11217-5-git-send-email-eblake@redhat.com>
In-Reply-To: <1406118378-11217-5-git-send-email-eblake@redhat.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 for-2.1 4/5] docs: document missing
	POWERDOWN event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, lcapitulino@redhat.com

ÓÚ 2014/7/23 20:26, Eric Blake дµÀ:
> The POWERDOWN event was first documented in 0aab9ec3.  But since
> dfab4892 later restored this file to the state prior to qmp events,
> and we never documented it in the past, anyone using this file
> instead of qapi will miss out on this event.  Tweak the existing
> wording of SHUTDOWN to match 84321831, and make the difference
> between the two events apparent.
> 
> * docs/qmp/qmp-events.txt (POWERDOWN): Add.
> (SHUTDOWN): Tweak.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>   docs/qmp/qmp-events.txt | 16 +++++++++++++++-
>   1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> index 22d552f..9d7439e 100644
> --- a/docs/qmp/qmp-events.txt
> +++ b/docs/qmp/qmp-events.txt
> @@ -243,6 +243,19 @@ Data:
>     "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
>   }
> 
> +POWERDOWN
> +---------
> +
> +Emitted when the Virtual Machine is powered down through the power
> +control system, such as via ACPI.
> +
> +Data: None.
> +
> +Example:
> +
> +{ "event": "POWERDOWN",
> +    "timestamp": { "seconds": 1267040730, "microseconds": 682951 } }
> +
>   QUORUM_FAILURE
>   --------------
> 
> @@ -325,7 +338,8 @@ Example:
>   SHUTDOWN
>   --------
> 
> -Emitted when the Virtual Machine is powered down.
> +Emitted when the Virtual Machine has shut down, indicating that qemu
> +is about to exit.
> 
>   Data: None.
> 
  Nice to have explantion about the difference.