From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9xjL-0002eI-5t for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9xjG-0004J4-D0 for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:41:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9xjG-0004Ip-0v for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:41:14 -0400 Message-ID: <53CFC97D.2020406@redhat.com> Date: Wed, 23 Jul 2014 08:41:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406125538-27992-1-git-send-email-yanghy@cn.fujitsu.com> <1406125538-27992-4-git-send-email-yanghy@cn.fujitsu.com> In-Reply-To: <1406125538-27992-4-git-send-email-yanghy@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9fPxArXe7rEQh9w0iC8vWJsHL42UQDStf" Subject: Re: [Qemu-devel] [RFC PATCH 03/17] COLO migration: add a migration capability 'colo' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: GuiJianfeng@cn.fujitsu.com, mrhines@linux.vnet.ibm.com, eddie.dong@intel.com, dgilbert@redhat.com, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9fPxArXe7rEQh9w0iC8vWJsHL42UQDStf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2014 08:25 AM, Yang Hongyang wrote: > Add a migration capability 'colo'. If this capability is on, > The migration will never end, and the VM will be continuously > checkpointed. >=20 > Signed-off-by: Yang Hongyang > --- > include/qapi/qmp/qerror.h | 3 +++ > migration.c | 6 ++++++ > qapi-schema.json | 5 ++++- > 3 files changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h > index 902d1a7..226b805 100644 > --- a/include/qapi/qmp/qerror.h > +++ b/include/qapi/qmp/qerror.h > @@ -166,4 +166,7 @@ void qerror_report_err(Error *err); > #define QERR_SOCKET_CREATE_FAILED \ > ERROR_CLASS_GENERIC_ERROR, "Failed to create socket" > =20 > +#define QERR_COLO_UNSUPPORTED \ > + ERROR_CLASS_GENERIC_ERROR, "COLO is not currently supported, pleas= e rerun configure with --enable-colo option in order to support COLO feat= ure" Unless you plan on using this message in more than one place, we prefer that you don't add new #defines here. Instead, just use error_setg with the message inline. > +++ b/qapi-schema.json > @@ -491,10 +491,13 @@ > # @auto-converge: If enabled, QEMU will automatically throttle down th= e guest > # to speed up convergence of RAM migration. (since 1.6) > # > +# @colo: The migration will never end, and the VM will instead be cont= inuously > +# checkpointed. The feature is disabled by default. (since 2.1)= You missed 2.1. This has to be since 2.2. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9fPxArXe7rEQh9w0iC8vWJsHL42UQDStf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTz8l9AAoJEKeha0olJ0NqBlsH/i7yG9odNST/t7QLgFuae8QR 5Lv1yF8r6fKEidA/1gLcWkJ7ZgVmNAkOvPYqFDErsMMnhgOMfvGuGmUeNsfQVe6L 9BLaHErZPhnSTlUnGNjt0FTHMJ4doPp/P0V7SMRZvkG0LOkbd46ZqM+IP3mkcAOj yxYYSIGRi0Md7SUWYh++3ItMZefgMkvPudPiO9xdyZMkODDI97H1R0kdKZ4ufvHw mFXf2fH6E4WWwhWndZ+M4RXZBt/c01KyzfcrKYTi9x/v5ztE2p6iQswv+SohZIEo tNb7cr0b12WBdYPDo/8i0Kp8RTzIcwZy6jTCHsOPLtZgx4pKX+Tky7erVq+NU30= =iF18 -----END PGP SIGNATURE----- --9fPxArXe7rEQh9w0iC8vWJsHL42UQDStf--