From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9y3C-0002TT-Os for qemu-devel@nongnu.org; Wed, 23 Jul 2014 11:01:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9y37-0003Dp-Eo for qemu-devel@nongnu.org; Wed, 23 Jul 2014 11:01:50 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:39076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9y37-0003Di-8g for qemu-devel@nongnu.org; Wed, 23 Jul 2014 11:01:45 -0400 Received: by mail-wi0-f172.google.com with SMTP id n3so7966077wiv.5 for ; Wed, 23 Jul 2014 08:01:44 -0700 (PDT) Message-ID: <53CFCE3D.6020602@linaro.org> Date: Wed, 23 Jul 2014 17:01:17 +0200 From: Eric Auger MIME-Version: 1.0 References: <1404716892-15600-1-git-send-email-eric.auger@linaro.org> <1404716892-15600-5-git-send-email-eric.auger@linaro.org> <53BBF74C.3060104@suse.de> In-Reply-To: <53BBF74C.3060104@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/7] hw/arm/virt: Support dynamically spawned sysbus devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com Cc: peter.maydell@linaro.org, patches@linaro.org, stuart.yoder@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu On 07/08/2014 03:51 PM, Alexander Graf wrote: > > On 07.07.14 09:08, Eric Auger wrote: >> Allows sysbus devices to be instantiated from command line by >> using -device option >> >> --- >> >> Inspired from what Alex Graf did in ppc e500 >> https://lists.gnu.org/archive/html/qemu-ppc/2014-07/msg00012.html >> >> Signed-off-by: Alexander Graf >> Signed-off-by: Eric Auger >> --- >> hw/arm/virt.c | 58 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 57 insertions(+), 1 deletion(-) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index eeecdbf..3a21db4 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -40,6 +40,8 @@ >> #include "exec/address-spaces.h" >> #include "qemu/bitops.h" >> #include "qemu/error-report.h" >> +#include "hw/misc/platform_devices.h" >> +#include "hw/vfio/vfio-platform.h" >> #define NUM_VIRTIO_TRANSPORTS 32 >> @@ -57,6 +59,14 @@ >> #define GIC_FDT_IRQ_PPI_CPU_START 8 >> #define GIC_FDT_IRQ_PPI_CPU_WIDTH 8 >> +#define MACHVIRT_PLATFORM_BASE 0xa004000 > > That's an odd address for a 128MB window. Can you make it 128MB aligned? > Maybe move the virtio region behind this one? Yes you're right. I didn't pay attention to that. Now we have to find a hole agreed with everybody if that's feasible ;-) > > With a bit of smartness we don't need a virtio-mmio region with this > patch set anymore btw. We could just generate the virtio-mmio devices on > our platform bus on the fly. > >> +#define MACHVIRT_PLATFORM_HOLE (128ULL * 1024 * 1024) /* 128 >> MB */ > > As Scott mentioned in the e500 review round, "hole" is an odd name ;). OK I will rename that. > > > Alex >