From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9ylG-0001OQ-Vn for qemu-devel@nongnu.org; Wed, 23 Jul 2014 11:47:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9yl8-0004RC-KS for qemu-devel@nongnu.org; Wed, 23 Jul 2014 11:47:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9yl8-0004Pq-Ai for qemu-devel@nongnu.org; Wed, 23 Jul 2014 11:47:14 -0400 Message-ID: <53CFD8FB.6060508@redhat.com> Date: Wed, 23 Jul 2014 09:47:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406125538-27992-1-git-send-email-yanghy@cn.fujitsu.com> <1406125538-27992-3-git-send-email-yanghy@cn.fujitsu.com> In-Reply-To: <1406125538-27992-3-git-send-email-yanghy@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BujeDGnjMvfNTqFCcN895vaHgMIRu4Tbd" Subject: Re: [Qemu-devel] [RFC PATCH 02/17] COLO: introduce an api colo_supported() to indicate COLO support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: GuiJianfeng@cn.fujitsu.com, mrhines@linux.vnet.ibm.com, eddie.dong@intel.com, dgilbert@redhat.com, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BujeDGnjMvfNTqFCcN895vaHgMIRu4Tbd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2014 08:25 AM, Yang Hongyang wrote: > introduce an api colo_supported() to indicate COLO support, returns > true if colo supported(configured with --enable-colo). Space before () in English sentences: s/supported(configured/supported (configured/ As I mentioned in the cover letter, defaulting to off is probably a bad idea; I'd rather default to on or even make it unconditional if it doesn't negatively affect the code base when not used. >=20 > Signed-off-by: Yang Hongyang > --- > Makefile.objs | 1 + > include/migration/migration-colo.h | 18 ++++++++++++++++++ > migration-colo.c | 16 ++++++++++++++++ > stubs/Makefile.objs | 1 + > stubs/migration-colo.c | 16 ++++++++++++++++ > 5 files changed, 52 insertions(+) > create mode 100644 include/migration/migration-colo.h > create mode 100644 migration-colo.c > create mode 100644 stubs/migration-colo.c >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BujeDGnjMvfNTqFCcN895vaHgMIRu4Tbd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTz9j7AAoJEKeha0olJ0Nq27kH/A5rrG6g6vFhd9wFpE4KU7W7 DMYjC3psqq7GlOrxBHODskCFWBf5TzAmKgwM5UpnpK/tMn9sBna+QteXJ+w01n5y pOtF13ulhSCM5J6p9r3fpfqPJwT/2B4Cv1frttXv3T2s6fANBd1WFrVR6LyOVbAp fucbmyOZ/i5+VW4GHM6MTSa1JKv9Cexe36AW5JN4knJiVH7FNesGJytJgvzpPIsp PYdJjHblHOCMnk5fXUBb58NcoKKn2jWlS9qg2kt8/KBkKT1jMxK/iV3o9jW+diAk FTb44D5y85IEHFYt0zRa1ECbSBbl4phiyROVtnXFtVJMvyBk3ECkqwXNTl+f88Y= =TSU4 -----END PGP SIGNATURE----- --BujeDGnjMvfNTqFCcN895vaHgMIRu4Tbd--