From: Eric Blake <eblake@redhat.com>
To: Bug 1347555 <1347555@bugs.launchpad.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1347555] [NEW] qemu build failure, hxtool is a bash script, not a /bin/sh script
Date: Wed, 23 Jul 2014 09:57:07 -0600 [thread overview]
Message-ID: <53CFDB53.9070007@redhat.com> (raw)
In-Reply-To: <20140723102116.9178.33943.malonedeb@gac.canonical.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On 07/23/2014 04:21 AM, Felix von Leitner wrote:
> Public bug reported:
>
> hxtool (part of the early build process) is a bash script. Running it
> with /bin/sh yields a syntax error on line 10:
>
> 10 STEXI*|ETEXI*|SQMP*|EQMP*) flag=$(($flag^1))
>
> $(( expr )) is a bash extension, not part of /bin/sh.
Wrong. $(( expr )) is mandated by POSIX. What system are you on where
/bin/sh is not POSIX? (Solaris is the only platform where /bin/sh does
not try to be POSIX-compliant, but who uses that for qemu?)
What is the actual syntax error you are seeing? Is this a bug in dash
on your distribution? I can't get dash to fail for me on Fedora:
$ dash -c 'f=1; f=$(($f^1)); echo $f'
0
$ dash -n scripts/hxtool; echo $?
0
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-07-23 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 10:21 [Qemu-devel] [Bug 1347555] [NEW] qemu build failure, hxtool is a bash script, not a /bin/sh script Felix von Leitner
2014-07-23 15:57 ` Eric Blake [this message]
2014-07-23 16:13 ` [Qemu-devel] [Bug 1347555] " Felix von Leitner
2014-07-23 16:31 ` Eric Blake
2014-07-23 17:15 ` Peter Maydell
2014-07-24 9:17 ` Felix von Leitner
2017-09-27 15:15 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFDB53.9070007@redhat.com \
--to=eblake@redhat.com \
--cc=1347555@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).