From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9zRe-00012n-PY for qemu-devel@nongnu.org; Wed, 23 Jul 2014 12:31:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9zRZ-0003VJ-0Q for qemu-devel@nongnu.org; Wed, 23 Jul 2014 12:31:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9zRY-0003VE-Mt for qemu-devel@nongnu.org; Wed, 23 Jul 2014 12:31:04 -0400 Message-ID: <53CFE345.3020100@redhat.com> Date: Wed, 23 Jul 2014 10:31:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140723102116.9178.33943.malonedeb@gac.canonical.com> <20140723161355.32453.35497.malone@chaenomeles.canonical.com> In-Reply-To: <20140723161355.32453.35497.malone@chaenomeles.canonical.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9o3VGhnAxbaK3JAo5JRUg7UkJlMHtFqEv" Subject: Re: [Qemu-devel] [Bug 1347555] Re: qemu build failure, hxtool is a bash script, not a /bin/sh script List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1347555 <1347555@bugs.launchpad.net>, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9o3VGhnAxbaK3JAo5JRUg7UkJlMHtFqEv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2014 10:13 AM, Felix von Leitner wrote: > I actually have bash installed as /bin/sh and /bin/bash. > But I also have heirloom sh installed, which installs itself as /sbin/s= h, and that happened to be first in my $PATH. >=20 > Since the makefiles use "sh script" to run the scripts, that called the= > heirloom sh. >=20 > http://heirloom.sourceforge.net/sh.html >=20 > It is, it turns out, derived from OpenSolaris. So there you go :-) >=20 > When I delete /sbin/sh, qemu builds. Then the bug is not in qemu, but in your environment. Installing known-broken heirloom where it can be found first on a PATH search for sh is just asking for problems, not just with qemu, but with all SORTS of programs that expect POSIX semantics from a Linux /bin/sh. Rather than change the Makefile to invoke the script with bash, we could instead bend over backwards to rewrite the script in a way that works with non-POSIX shells (as in, flag=3D`expr $flag ^ 1`), but that feels backwards to me. Until someone is actively worried about porting qemu to a true Solaris environment, rather than just an heirloom-as-/bin/sh Linux environment, I don't think it's worth the effort. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9o3VGhnAxbaK3JAo5JRUg7UkJlMHtFqEv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEbBAEBCAAGBQJTz+NFAAoJEKeha0olJ0NqWFIH+P9C83VtvNzCCHIKrOx2qHax 2lfuUyAL2WcMhpKkiIjHryprsHIrWuEkTggg8WNINM1QZVA5XNy1einsT5I2GFw+ IMkSwAcXU5tgroSD6D81S7nyxqh+0CAOIqCbpe2war7NBVYMROXauH+MdrHfi3uf kOMwEAhzOffsEJM/EjoB38l2Uz1eK5kZoDKRl8MM/lsMJHLzXoJz2F0ecKrogPpQ ZF2W0wwi6067AhE4hjaGLjI1RHLz0kgWNdjGNd+FO63jH+rjTwllsO9vbiGzTyhG 5rm36GHi72ix7orqLG8KygbUeekYs/avzP5BpE4qoqZWivHkN7vGbHAhQc24XA== =6iH1 -----END PGP SIGNATURE----- --9o3VGhnAxbaK3JAo5JRUg7UkJlMHtFqEv--