From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XALe7-0005ul-2Y for qemu-devel@nongnu.org; Thu, 24 Jul 2014 12:13:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XALdz-0001be-DW for qemu-devel@nongnu.org; Thu, 24 Jul 2014 12:13:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XALdz-0001bY-6X for qemu-devel@nongnu.org; Thu, 24 Jul 2014 12:13:23 -0400 Message-ID: <53D1309E.8070207@redhat.com> Date: Thu, 24 Jul 2014 18:13:18 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1406212329-24439-1-git-send-email-pbonzini@redhat.com> <1406212329-24439-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1406212329-24439-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-2.1 1/2] acpi-dsdt: procedurally generate _PRT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, peter.maydell@linaro.org, dgilbert@redhat.com, mst@redhat.com On 07/24/14 16:32, Paolo Bonzini wrote: > This replaces the _PRT constant with a method that computes it. > > The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, > enough to cross the 8k barrier (we align the ACPI tables to 4k > before putting them in fw_cfg). This causes problems with > migration and the pc-i440fx-2.0 machine type. > > The solution to the problem is to hardcode 64k as the limit, > but this doesn't solve the bug with pc-i440fx-2.0. The fix will be > for QEMU 2.1 to use exactly the same size as QEMU 2.0 for the > ACPI tables. First, however, we must make the actual AML > equal or smaller; to do this, rewrite _PRT in a way that saves > over 1k of bytecode. > > Signed-off-by: Paolo Bonzini > --- > include cpi-dsdt.hex.generated [Igor] > > hw/i386/acpi-dsdt.dsl | 90 +- > hw/i386/acpi-dsdt.hex.generated | 1910 +++------------------------------------ > 2 files changed, 148 insertions(+), 1852 deletions(-) Compared with v1, v2 1/2 seems to reword the commit message a little bit, and add the generated file (requested by Igor, and mentioned by you anyway). Reviewed-by: Laszlo Ersek