From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAa8K-0000sZ-2L for qemu-devel@nongnu.org; Fri, 25 Jul 2014 03:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAa8B-0005P3-1u for qemu-devel@nongnu.org; Fri, 25 Jul 2014 03:41:40 -0400 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:64500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAa8A-0005Ox-Qe for qemu-devel@nongnu.org; Fri, 25 Jul 2014 03:41:30 -0400 Received: by mail-pa0-f45.google.com with SMTP id eu11so5583037pac.18 for ; Fri, 25 Jul 2014 00:41:29 -0700 (PDT) Sender: Richard Henderson Message-ID: <53D20A24.8060508@twiddle.net> Date: Thu, 24 Jul 2014 21:41:24 -1000 From: Richard Henderson MIME-Version: 1.0 References: <1406263073-635-1-git-send-email-jmiao@redhat.com> <53D20027.7090000@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , Jincheng Miao , QEMU Developers On 07/24/2014 09:37 PM, Peter Maydell wrote: > Huh? We already don't emit goto_tb if single-stepping, surely? > (Well, I guess some of the backends might well be broken, but > in that case they probably don't get the other bits of singlestep > support right either...) Indeed. I noticed this a month or so ago. Almost all backends check the gdb env->single_step to prevent goto_tb, but forget about the tcg debugging singlestep. r~