From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBIZX-00037t-8j for qemu-devel@nongnu.org; Sun, 27 Jul 2014 03:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBIZR-0006ne-BE for qemu-devel@nongnu.org; Sun, 27 Jul 2014 03:08:43 -0400 Received: from mout.web.de ([212.227.15.3]:60535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBIZR-0006nX-04 for qemu-devel@nongnu.org; Sun, 27 Jul 2014 03:08:37 -0400 Message-ID: <53D4A56D.3070703@web.de> Date: Sun, 27 Jul 2014 09:08:29 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="emRwpm5lmrEg748fTTfMItTJVJbCvPeoK" Subject: [Qemu-devel] [PATCH] pci: Use bus master address space for delivering MSI/MSI-X messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --emRwpm5lmrEg748fTTfMItTJVJbCvPeoK Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable From: Jan Kiszka The spec says (and real HW confirms this) that, if the bus master bit is 0, the device will not generate any PCI accesses. MSI and MSI-X messages fall among these, so we should use the corresponding address space to deliver them. This will prevent delivery if bus master support is disabled. Signed-off-by: Jan Kiszka --- hw/pci/msi.c | 2 +- hw/pci/msix.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/msi.c b/hw/pci/msi.c index a4a3040..52d2313 100644 --- a/hw/pci/msi.c +++ b/hw/pci/msi.c @@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector) "notify vector 0x%x" " address: 0x%"PRIx64" data: 0x%"PRIx32"\n", vector, msg.address, msg.data); - stl_le_phys(&address_space_memory, msg.address, msg.data); + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); } =20 /* Normally called by pci_default_write_config(). */ diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 5c49bfc..20ae476 100644 --- a/hw/pci/msix.c +++ b/hw/pci/msix.c @@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector) =20 msg =3D msix_get_message(dev, vector); =20 - stl_le_phys(&address_space_memory, msg.address, msg.data); + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); } =20 void msix_reset(PCIDevice *dev) --=20 1.8.1.1.298.ge7eed54 --emRwpm5lmrEg748fTTfMItTJVJbCvPeoK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlPUpW0ACgkQitSsb3rl5xTf0ACgxodNTqNhg/gmcf7lcrxp3cXs P/wAnj94bQBaRDNnJCElYCrPl8VRcU47 =hMVq -----END PGP SIGNATURE----- --emRwpm5lmrEg748fTTfMItTJVJbCvPeoK--