From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBPAC-00065P-AL for qemu-devel@nongnu.org; Sun, 27 Jul 2014 10:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBPA6-0008SY-Ud for qemu-devel@nongnu.org; Sun, 27 Jul 2014 10:11:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45892 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBPA6-0008SP-Nr for qemu-devel@nongnu.org; Sun, 27 Jul 2014 10:10:54 -0400 Message-ID: <53D5086B.9070008@suse.de> Date: Sun, 27 Jul 2014 16:10:51 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1406054580-16763-1-git-send-email-alex@alex.org.uk> In-Reply-To: <1406054580-16763-1-git-send-email-alex@alex.org.uk> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh , qemu-devel@nongnu.org Cc: Juan Quintela , Libvirt , "Michael S. Tsirkin" , Alexander Graf , Bruce Rogers , Cole Robinson , Amit Shah , Paolo Bonzini Hi Alex, + quintela, mst, libvirt Am 22.07.2014 20:43, schrieb Alex Bligh: > Add a machine type pc-1.0-qemu-kvm for live migrate compatibility > with qemu-kvm version 1.0. >=20 > Signed-off-by: Alex Bligh > --- > hw/acpi/piix4.c | 49 ++++++++++++++++++++++++++++++++++++++= ++++++-- > hw/i386/pc_piix.c | 31 +++++++++++++++++++++++++++++ > hw/timer/i8254_common.c | 41 ++++++++++++++++++++++++++++++++++++++ > include/hw/acpi/piix4.h | 1 + > include/hw/timer/i8254.h | 2 ++ > 5 files changed, 122 insertions(+), 2 deletions(-) >=20 > This RFC patch adds inbound migrate capability from qemu-kvm version > 1.0. The main ideas are those set out in Cole Robinson's patch here: > http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-fro= m-qemu-kvm.patch?h=3Df20 > however, rather than patching statically (and breaking inbound > migration on existing machine types), I have added a new machine > type (pc-1.0-qemu-kvm) without affecting any other machine types. This sounds like a really cool feature that SUSE would probably be interested in extending back to 0.14 and 0.15, but I see a fundamental flaw: libvirt on those old source systems does not know it should use a different machine name on the destination side and would still use pc-1.0, wouldn't it? After all, it needs to be able to migrate to other old qemu-kvm machines, so it can't just be updated to use the new name. Minor bikeshedding: I would ask to keep the package name in front of the machine version, e.g. qemu-kvm-pc-1.0. Or just kvm-pc-1.0 since this is a QEMU parameter anyway. Haven't reviewed the code in detail yet. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg