From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBg2v-0002uj-5F for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:12:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBg2m-00083d-WF for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:12:37 -0400 Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:39031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBg2m-00083U-PD for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:12:28 -0400 Received: by mail-we0-f182.google.com with SMTP id k48so7051790wev.27 for ; Mon, 28 Jul 2014 01:12:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53D605E5.8090808@redhat.com> Date: Mon, 28 Jul 2014 10:12:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <53D4A56D.3070703@web.de> In-Reply-To: <53D4A56D.3070703@web.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci: Use bus master address space for delivering MSI/MSI-X messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , "Michael S. Tsirkin" Cc: qemu-devel Il 27/07/2014 09:08, Jan Kiszka ha scritto: > From: Jan Kiszka > > The spec says (and real HW confirms this) that, if the bus master bit > is 0, the device will not generate any PCI accesses. MSI and MSI-X > messages fall among these, so we should use the corresponding address > space to deliver them. This will prevent delivery if bus master support > is disabled. > > Signed-off-by: Jan Kiszka > --- > hw/pci/msi.c | 2 +- > hw/pci/msix.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/pci/msi.c b/hw/pci/msi.c > index a4a3040..52d2313 100644 > --- a/hw/pci/msi.c > +++ b/hw/pci/msi.c > @@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector) > "notify vector 0x%x" > " address: 0x%"PRIx64" data: 0x%"PRIx32"\n", > vector, msg.address, msg.data); > - stl_le_phys(&address_space_memory, msg.address, msg.data); > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); > } > > /* Normally called by pci_default_write_config(). */ > diff --git a/hw/pci/msix.c b/hw/pci/msix.c > index 5c49bfc..20ae476 100644 > --- a/hw/pci/msix.c > +++ b/hw/pci/msix.c > @@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector) > > msg = msix_get_message(dev, vector); > > - stl_le_phys(&address_space_memory, msg.address, msg.data); > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); > } > > void msix_reset(PCIDevice *dev) > Reviewed-by: Paolo Bonzini