[Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address

[Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

From: Jan Kiszka <jan.kiszka@siemens.com>

According to ICH9 spec, the MSI capability is located at 0x60. This is
important for guest drivers that do not parse the capability chain and
use absolute addresses instead.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/audio/intel-hda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index aa49b47..09c4118 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci)
                           "intel-hda", 0x4000);
     pci_register_bar(&d->pci, 0, 0, &d->mmio);
     if (d->msi) {
-        msi_init(&d->pci, 0x50, 1, true, false);
+        msi_init(&d->pci, 0x60, 1, true, false);
     }

     hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),
-- 
1.8.1.1.298.ge7eed54


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address

[Paolo Bonzini]

Il 27/07/2014 08:57, Jan Kiszka ha scritto:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> According to ICH9 spec, the MSI capability is located at 0x60. This is
> important for guest drivers that do not parse the capability chain and
> use absolute addresses instead.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/audio/intel-hda.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
> index aa49b47..09c4118 100644
> --- a/hw/audio/intel-hda.c
> +++ b/hw/audio/intel-hda.c
> @@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci)
>                            "intel-hda", 0x4000);
>      pci_register_bar(&d->pci, 0, 0, &d->mmio);
>      if (d->msi) {
> -        msi_init(&d->pci, 0x50, 1, true, false);
> +        msi_init(&d->pci, 0x60, 1, true, false);
>      }
> 
>      hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),
> 

Does this need a compat property?

Paolo

Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On 2014-07-28 10:11, Paolo Bonzini wrote:
> Il 27/07/2014 08:57, Jan Kiszka ha scritto:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> According to ICH9 spec, the MSI capability is located at 0x60. This is
>> important for guest drivers that do not parse the capability chain and
>> use absolute addresses instead.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  hw/audio/intel-hda.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
>> index aa49b47..09c4118 100644
>> --- a/hw/audio/intel-hda.c
>> +++ b/hw/audio/intel-hda.c
>> @@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci)
>>                            "intel-hda", 0x4000);
>>      pci_register_bar(&d->pci, 0, 0, &d->mmio);
>>      if (d->msi) {
>> -        msi_init(&d->pci, 0x50, 1, true, false);
>> +        msi_init(&d->pci, 0x60, 1, true, false);
>>      }
>>
>>      hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs),
>>
> 
> Does this need a compat property?

Sigh, right, it's guest visible.

Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]