From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBg4n-0004sV-RQ for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBg4h-00007m-Tz for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:14:33 -0400 Received: from mout.web.de ([212.227.15.14]:53840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBg4h-00006R-Ir for qemu-devel@nongnu.org; Mon, 28 Jul 2014 04:14:27 -0400 Message-ID: <53D6063F.2030109@web.de> Date: Mon, 28 Jul 2014 10:13:51 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <53D4A2C3.8030406@web.de> <53D605CF.1060508@redhat.com> In-Reply-To: <53D605CF.1060508@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QHWjgqObhQj8VH3vQq4atHW66i3NHeW3s" Subject: Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Gerd Hoffmann Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QHWjgqObhQj8VH3vQq4atHW66i3NHeW3s Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2014-07-28 10:11, Paolo Bonzini wrote: > Il 27/07/2014 08:57, Jan Kiszka ha scritto: >> From: Jan Kiszka >> >> According to ICH9 spec, the MSI capability is located at 0x60. This is= >> important for guest drivers that do not parse the capability chain and= >> use absolute addresses instead. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/audio/intel-hda.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c >> index aa49b47..09c4118 100644 >> --- a/hw/audio/intel-hda.c >> +++ b/hw/audio/intel-hda.c >> @@ -1141,7 +1141,7 @@ static int intel_hda_init(PCIDevice *pci) >> "intel-hda", 0x4000); >> pci_register_bar(&d->pci, 0, 0, &d->mmio); >> if (d->msi) { >> - msi_init(&d->pci, 0x50, 1, true, false); >> + msi_init(&d->pci, 0x60, 1, true, false); >> } >> >> hda_codec_bus_init(DEVICE(pci), &d->codecs, sizeof(d->codecs), >> >=20 > Does this need a compat property? Sigh, right, it's guest visible. Jan --QHWjgqObhQj8VH3vQq4atHW66i3NHeW3s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlPWBkIACgkQitSsb3rl5xSCsQCg4QB8oL4mo3KPaF2gmn7e6M7A sr4An3g0/P0CgAvdmyR7hEdjdcj3TtCH =KLEU -----END PGP SIGNATURE----- --QHWjgqObhQj8VH3vQq4atHW66i3NHeW3s--