From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBhur-0005dP-Uy for qemu-devel@nongnu.org; Mon, 28 Jul 2014 06:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBhui-0006mm-Uy for qemu-devel@nongnu.org; Mon, 28 Jul 2014 06:12:25 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:55740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBhui-0006mg-Ns for qemu-devel@nongnu.org; Mon, 28 Jul 2014 06:12:16 -0400 Received: by mail-wi0-f179.google.com with SMTP id f8so4075147wiw.6 for ; Mon, 28 Jul 2014 03:12:14 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53D621F5.9050906@redhat.com> Date: Mon, 28 Jul 2014 12:12:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140717110153.8352.80175.stgit@PASHA-ISP> <20140717110255.8352.73575.stgit@PASHA-ISP> <53D61AE3.6000700@redhat.com> <37740.9009532586$1406541296@news.gmane.org> In-Reply-To: <37740.9009532586$1406541296@news.gmane.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, fred.konrad@greensocs.com Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto: >>> > > + VMSTATE_TIMER_V(timer, RTL8139State, 5), >> > >> > timer need not be migrated, because it is reinstated by rtl8139_post_load. >> > > That's true for normal execution. > In replay execution mode post_load can be called before cached virtual clock > values are loaded. This may cause invalid setting of the timer and raising > an IRQ which didn't happen in record mode. > I will update this patch to fix post_load function and avoid this > non-deterministic behavior. This is what worries me of this series. These invariants are not documented anywhere, and people will break them unless you add assertions that also hold in normal mode. Paolo