From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: imammedo@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0
Date: Mon, 28 Jul 2014 17:06:37 +0200 [thread overview]
Message-ID: <53D666FD.7080105@redhat.com> (raw)
In-Reply-To: <20140728150505.GA12174@redhat.com>
Il 28/07/2014 17:05, Michael S. Tsirkin ha scritto:
>> > +/* These are used to size the ACPI tables for -M pc-i440fx-1.7 and
>> > + * -M pc-i440fx-2.0. Even if the actual amount of AML generated grows
>> > + * a little bit, there should be plenty of free space since the DSDT
>> > + * shrunk by ~1.5k between QEMU 2.0 and QEMU 2.1.
>> > + */
>> > +#define ACPI_BUILD_LEGACY_CPU_AML_SIZE 97
>> > +#define ACPI_BUILD_LEGACY_BRIDGE_AML_SIZE 1872
>
> Hmm this is wrong if some slot is occupied by a
> non hotpluggable device, is it not?
I honestly have no idea. If even more complicated code is needed, I'd
rather get rid of all this bridge stuff altogether (as far as computing
the AML size goes), and declare 2.0->2.1 migration broken if the VM has
bridges.
Paolo
next prev parent reply other threads:[~2014-07-28 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 14:02 [Qemu-devel] [PATCH v3 0/5] ACPI fixes for QEMU 2.1 Paolo Bonzini
2014-07-28 14:02 ` [Qemu-devel] [PATCH 1/5] acpi-dsdt: procedurally generate _PRT Paolo Bonzini
2014-07-28 14:02 ` [Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0 Paolo Bonzini
2014-07-28 15:05 ` Michael S. Tsirkin
2014-07-28 15:06 ` Paolo Bonzini [this message]
2014-07-28 14:02 ` [Qemu-devel] [PATCH 3/5] pc: future-proof migration-compatibility of ACPI tables Paolo Bonzini
2014-07-28 14:02 ` [Qemu-devel] [PATCH 4/5] bios-tables-test: fix ASL normalization false positive Paolo Bonzini
2014-07-28 14:02 ` [Qemu-devel] [PATCH 5/5] pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug is disabled Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-07-28 15:34 [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1 Paolo Bonzini
2014-07-28 15:34 ` [Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D666FD.7080105@redhat.com \
--to=pbonzini@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).