From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XBmVl-0007fK-SG
	for qemu-devel@nongnu.org; Mon, 28 Jul 2014 11:06:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XBmVe-0007y9-Ct
	for qemu-devel@nongnu.org; Mon, 28 Jul 2014 11:06:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50546)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XBmVe-0007y2-5A
	for qemu-devel@nongnu.org; Mon, 28 Jul 2014 11:06:42 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6SF6f5p003302
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 28 Jul 2014 11:06:41 -0400
Message-ID: <53D666FD.7080105@redhat.com>
Date: Mon, 28 Jul 2014 17:06:37 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1406556135-31717-1-git-send-email-pbonzini@redhat.com>
	<1406556135-31717-3-git-send-email-pbonzini@redhat.com>
	<20140728150505.GA12174@redhat.com>
In-Reply-To: <20140728150505.GA12174@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility
	from QEMU 2.0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: imammedo@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org

Il 28/07/2014 17:05, Michael S. Tsirkin ha scritto:
>> > +/* These are used to size the ACPI tables for -M pc-i440fx-1.7 and
>> > + * -M pc-i440fx-2.0.  Even if the actual amount of AML generated grows
>> > + * a little bit, there should be plenty of free space since the DSDT
>> > + * shrunk by ~1.5k between QEMU 2.0 and QEMU 2.1.
>> > + */
>> > +#define ACPI_BUILD_LEGACY_CPU_AML_SIZE    97
>> > +#define ACPI_BUILD_LEGACY_BRIDGE_AML_SIZE 1872
> 
> Hmm this is wrong if some slot is occupied by a
> non hotpluggable device, is it not?

I honestly have no idea.  If even more complicated code is needed, I'd
rather get rid of all this bridge stuff altogether (as far as computing
the AML size goes), and declare 2.0->2.1 migration broken if the VM has
bridges.

Paolo