From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBq8C-00089H-EN for qemu-devel@nongnu.org; Mon, 28 Jul 2014 14:58:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBq85-0006hz-HL for qemu-devel@nongnu.org; Mon, 28 Jul 2014 14:58:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBq85-0006hu-84 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 14:58:37 -0400 Message-ID: <53D69D59.8060207@redhat.com> Date: Mon, 28 Jul 2014 12:58:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404873793-7999-1-git-send-email-cyliu@suse.com> <20140728151941.GH13872@stefanha-thinkpad.redhat.com> In-Reply-To: <20140728151941.GH13872@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E5moCDXlmvsrO9d8Lm9jfOnf09OvvdhNx" Subject: Re: [Qemu-devel] [PATCH for 2.1 V3] qemu-img info: show nocow info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E5moCDXlmvsrO9d8Lm9jfOnf09OvvdhNx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/28/2014 09:19 AM, Stefan Hajnoczi wrote: > On Wed, Jul 09, 2014 at 10:43:13AM +0800, Chunyan Liu wrote: >> Add nocow info in 'qemu-img info' output to show whether the file >> currently has NOCOW flag set or not. >> >> Signed-off-by: Chunyan Liu >> --- >> Changes: >> - update output info to "NOCOW flag: set" >> >> block/qapi.c | 25 +++++++++++++++++++++++++ >> qapi/block-core.json | 5 ++++- >> 2 files changed, 29 insertions(+), 1 deletion(-) >=20 > This patch was sent on July 9th, after the 2.1 soft freeze when we stop= > merging new features. Soft freeze was 17th of June. >=20 > Please resend for QEMU 2.2 and update the qapi-schema.json version > comment. There's still the argument that this is a bug fix for an incomplete implementation of a new feature that IS in qemu 2.1 (that is, 2.1 is adding the ability to set the nocow flag, but without this patch, that addition is a write-only interface, and this patch is correcting the bug to allow it to be a read-write interface). But it is fairly late in the game - what is the level of damage if 2.1 is released with a write-only setting, and this patch is deferred to 2.2? Without some strong justification, I can agree with the decision to postpone this patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E5moCDXlmvsrO9d8Lm9jfOnf09OvvdhNx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT1p1ZAAoJEKeha0olJ0Nqw28H/20I9diLD93HLxom1nTqevO2 Z7MGQDxrqMb5o7l05JqYPJuBjUjIcD6rVlYhD0XN8t8yiBBErYAmc54EUL/fkXfD /8klaIYQpKQ5G45Ymu7Ja8ie2knooUmqiCp97eSpbrJpP2iXKPndcVpJY+9va0uq 6FeqYcZWFNStOH+nmcYq5eQ/9TX+hxk+bTJ52LuOPQCknau3FHoAK2DUYT/jLPOd ncfKp55pCLSdh4RPNs6U3UlAG7OGH3jw/7Jj2cCWDf+qI3qclKWgLvcjUyGdBDYW N89SGq1zOxXDx25jSGFigR01PyVRoouiKehRutrp0OCUg5U0C+sU8657T2seGdU= =Z8TY -----END PGP SIGNATURE----- --E5moCDXlmvsrO9d8Lm9jfOnf09OvvdhNx--