From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBr4K-0001Bi-Fg for qemu-devel@nongnu.org; Mon, 28 Jul 2014 15:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBr4C-0001bj-NE for qemu-devel@nongnu.org; Mon, 28 Jul 2014 15:58:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBr4C-0001bc-GA for qemu-devel@nongnu.org; Mon, 28 Jul 2014 15:58:40 -0400 Message-ID: <53D6AB64.9090809@redhat.com> Date: Mon, 28 Jul 2014 13:58:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406576611-31715-1-git-send-email-pl@kamp.de> <1406576611-31715-2-git-send-email-pl@kamp.de> In-Reply-To: <1406576611-31715-2-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mBFxgbA2vgVkHhLlsre1mDjsA0jUq34Ld" Subject: Re: [Qemu-devel] [PATCH for-2.2 1/2] rename parse_enum_option to qapi_enum_parse and make it public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, hutao@cn.fujitsu.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mBFxgbA2vgVkHhLlsre1mDjsA0jUq34Ld Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/28/2014 01:43 PM, Peter Lieven wrote: > Suggested-by: Markus Armbruster > Signed-off-by: Hu Tao > Signed-off-by: Peter Lieven > --- > blockdev.c | 30 ++++++------------------------ > include/qapi/util.h | 17 +++++++++++++++++ > qapi/Makefile.objs | 2 +- > qapi/qapi-util.c | 34 ++++++++++++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 25 deletions(-) > create mode 100644 include/qapi/util.h > create mode 100644 qapi/qapi-util.c > +++ b/blockdev.c > @@ -39,6 +39,7 @@ > #include "qapi/qmp/types.h" > #include "qapi-visit.h" > #include "qapi/qmp-output-visitor.h" > +#include "qapi/util.h" > #include "sysemu/sysemu.h" > #include "block/block_int.h" > #include "qmp-commands.h" > @@ -274,25 +275,6 @@ static int parse_block_error_action(const char *bu= f, bool is_read, Error **errp) > } > } > =20 > -static inline int parse_enum_option(const char *lookup[], const char *= buf, > - int max, int def, Error **errp) This file is GPLv2+,... > +++ b/qapi/qapi-util.c > @@ -0,0 +1,34 @@ > +/* > + * QAPI util functions > + * > + * Authors: > + * Hu Tao > + * Peter Lieven > + * > + * This work is licensed under the terms of the GNU LGPL, version 2.1 = or later. > + * See the COPYING.LIB file in the top-level directory. =2E..but you have relaxed the license to LGPLv2+ in your code motion. Then again, Peter is the original author of this code in commit 82a402e9, so you have the legal right to relax things. If this was intentional, then it probably should have been mentioned in the commit message. With that done: Reviewed-by: Eric Blake If it was inadvertent, then post a v2 that makes the new file GPLv2+, for the avoidance of doubt. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mBFxgbA2vgVkHhLlsre1mDjsA0jUq34Ld Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT1qtkAAoJEKeha0olJ0Nq/CkIAKmxs39HaNlN5HLvhv44ukwQ r88cIFsCNWXEYPkeIhq7AVS4sOTjVEP7sRIwS54etjQsTYYG4o52A2xxyg17Cxgj xH4HJrW36f4fumha9dGK6CRWoe3s+/ecdyBTZfptHK4nrGBWshAdhgI2kA2HL9fd cNPrvVXI1lhd39EfJ2VJFsrwFEHl/8dX99RmU+z186pCDPLVAH01WO/EPlTXUf23 LeDOXtRJYs9IEtevudGFFZ4Ze/0q4uCfFQfUPmu+CwGXzTk1Vo1TRpD3LMnSTqc5 PKJIkIbOprgBXKvybd11/DmBDOizLfIUmnfdy3j7KTARo3lPDpwLErBv9QLg2hI= =uVgA -----END PGP SIGNATURE----- --mBFxgbA2vgVkHhLlsre1mDjsA0jUq34Ld--