From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBr7N-0002HE-A0 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 16:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBr7H-0002YH-2y for qemu-devel@nongnu.org; Mon, 28 Jul 2014 16:01:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBr7G-0002YD-Pr for qemu-devel@nongnu.org; Mon, 28 Jul 2014 16:01:50 -0400 Message-ID: <53D6AC24.8000507@redhat.com> Date: Mon, 28 Jul 2014 14:01:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406576611-31715-1-git-send-email-pl@kamp.de> <1406576611-31715-3-git-send-email-pl@kamp.de> In-Reply-To: <1406576611-31715-3-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GfU94a65OrbTEKwOnTETMq6rRLOPBosTF" Subject: Re: [Qemu-devel] [PATCH for-2.2 2/2] qemu-nbd: add option to set detect-zeroes mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, hutao@cn.fujitsu.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GfU94a65OrbTEKwOnTETMq6rRLOPBosTF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/28/2014 01:43 PM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > qemu-nbd.c | 81 +++++++++++++++++++++++++++++++++++++++-------------= -------- > 1 file changed, 53 insertions(+), 28 deletions(-) >=20 > @@ -57,45 +60,47 @@ static void usage(const char *name) > "Usage: %s [OPTIONS] FILE\n" > "QEMU Disk Network Block Device Server\n" > "\n" > -" -h, --help display this help and exit\n" > -" -V, --version output version information and exit\n" > +" -h, --help display this help and exit\n" > +" -V, --version output version information and exit\n" More than 50% of this patch is reformatting existing code to prepare for new whitespace alignment. It makes it a bit harder to find the meat of the patch; I might have split the realignment and the code additions into separate commits. Not a reason for a respin by itself, but food for thought if you do a v2. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GfU94a65OrbTEKwOnTETMq6rRLOPBosTF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT1qwkAAoJEKeha0olJ0NqKr4H/35g4vitaNM4mNSFEvLul1FA Xb2XEMcDR1vdjdI2ZkcyvX0ure6faUScYUfZdPaNOSjePyTOVJjk5TDVFFNvoh1q UiYkNMFT37VrPnOxJ1DONeDp1Y7kfJq/WpUavG2ujo9QvT44btKS293QffO/DtAi t5lnZxbQOV2uj1dpAk1+RsPz0clYtbu8HkoalLnCThAfm11CBkX2rmonfZwQhVa1 rAU7PpE6bI9mggKG1F2qjE1QSxxmm2ZqyyJ29QnxXD0roJaSVOccA93LC1Za0/ui s08cqGRkXFs3l+vYE8GqyPpx8Z7p0Riynyf/wY46vFOCaEsymj/bBFxgHHJfugQ= =hPyl -----END PGP SIGNATURE----- --GfU94a65OrbTEKwOnTETMq6rRLOPBosTF--