* [Qemu-devel] [PATCH for-2.1] qemu-options: add missing -drive discard option to cmdline help
@ 2014-07-28 19:53 Peter Lieven
2014-07-28 20:02 ` Eric Blake
2014-08-12 12:59 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Peter Lieven @ 2014-07-28 19:53 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pbonzini, Peter Lieven, stefanha, peter.maydell
Signed-off-by: Peter Lieven <pl@kamp.de>
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 1549625..251535f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -427,7 +427,7 @@ DEF("drive", HAS_ARG, QEMU_OPTION_drive,
" [,serial=s][,addr=A][,rerror=ignore|stop|report]\n"
" [,werror=ignore|stop|report|enospc][,id=name][,aio=threads|native]\n"
" [,readonly=on|off][,copy-on-read=on|off]\n"
- " [,detect-zeroes=on|off|unmap]\n"
+ " [,discard=ignore|unmap][,detect-zeroes=on|off|unmap]\n"
" [[,bps=b]|[[,bps_rd=r][,bps_wr=w]]]\n"
" [[,iops=i]|[[,iops_rd=r][,iops_wr=w]]]\n"
" [[,bps_max=bm]|[[,bps_rd_max=rm][,bps_wr_max=wm]]]\n"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.1] qemu-options: add missing -drive discard option to cmdline help
2014-07-28 19:53 [Qemu-devel] [PATCH for-2.1] qemu-options: add missing -drive discard option to cmdline help Peter Lieven
@ 2014-07-28 20:02 ` Eric Blake
2014-08-12 12:59 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2014-07-28 20:02 UTC (permalink / raw)
To: Peter Lieven, qemu-devel; +Cc: kwolf, pbonzini, stefanha, peter.maydell
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
On 07/28/2014 01:53 PM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 1549625..251535f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -427,7 +427,7 @@ DEF("drive", HAS_ARG, QEMU_OPTION_drive,
> " [,serial=s][,addr=A][,rerror=ignore|stop|report]\n"
> " [,werror=ignore|stop|report|enospc][,id=name][,aio=threads|native]\n"
> " [,readonly=on|off][,copy-on-read=on|off]\n"
> - " [,detect-zeroes=on|off|unmap]\n"
> + " [,discard=ignore|unmap][,detect-zeroes=on|off|unmap]\n"
> " [[,bps=b]|[[,bps_rd=r][,bps_wr=w]]]\n"
> " [[,iops=i]|[[,iops_rd=r][,iops_wr=w]]]\n"
> " [[,bps_max=bm]|[[,bps_rd_max=rm][,bps_wr_max=wm]]]\n"
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.1] qemu-options: add missing -drive discard option to cmdline help
2014-07-28 19:53 [Qemu-devel] [PATCH for-2.1] qemu-options: add missing -drive discard option to cmdline help Peter Lieven
2014-07-28 20:02 ` Eric Blake
@ 2014-08-12 12:59 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-08-12 12:59 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, pbonzini, qemu-devel, peter.maydell
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
On Mon, Jul 28, 2014 at 09:53:02PM +0200, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-12 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-28 19:53 [Qemu-devel] [PATCH for-2.1] qemu-options: add missing -drive discard option to cmdline help Peter Lieven
2014-07-28 20:02 ` Eric Blake
2014-08-12 12:59 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).