From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] piix: set legacy table size for 1.7
Date: Tue, 29 Jul 2014 10:25:04 +0200 [thread overview]
Message-ID: <53D75A60.7070500@redhat.com> (raw)
In-Reply-To: <1406581257-7153-1-git-send-email-mst@redhat.com>
Il 28/07/2014 23:01, Michael S. Tsirkin ha scritto:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Paolo, so the following is needed on top of your patch?
>
> hw/i386/pc_piix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 4524e6b..9694f88 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -326,6 +326,7 @@ static void pc_compat_1_7(MachineState *machine)
> smbios_defaults = false;
> gigabyte_align = false;
> option_rom_has_mr = true;
> + legacy_acpi_table_size = 6414;
> x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC);
> }
Only if you want to support pc-i440fx-1.7 migration for 1.7->2.1 (and
not for 2.0->2.1). Probably better considering we're applying Igor's patch.
Paolo
prev parent reply other threads:[~2014-07-29 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 21:01 [Qemu-devel] [PATCH] piix: set legacy table size for 1.7 Michael S. Tsirkin
2014-07-29 8:25 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D75A60.7070500@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).