From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XC2ii-0003C6-CS
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 04:25:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XC2ib-0007vP-Qu
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 04:25:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43110)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XC2ib-0007v2-JH
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 04:25:09 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6T8P8c6021274
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 29 Jul 2014 04:25:08 -0400
Message-ID: <53D75A60.7070500@redhat.com>
Date: Tue, 29 Jul 2014 10:25:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1406581257-7153-1-git-send-email-mst@redhat.com>
In-Reply-To: <1406581257-7153-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] piix: set legacy table size for 1.7
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org

Il 28/07/2014 23:01, Michael S. Tsirkin ha scritto:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Paolo, so the following is needed on top of your patch?
> 
>  hw/i386/pc_piix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 4524e6b..9694f88 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -326,6 +326,7 @@ static void pc_compat_1_7(MachineState *machine)
>      smbios_defaults = false;
>      gigabyte_align = false;
>      option_rom_has_mr = true;
> +    legacy_acpi_table_size = 6414;
>      x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC);
>  }

Only if you want to support pc-i440fx-1.7 migration for 1.7->2.1 (and
not for 2.0->2.1).  Probably better considering we're applying Igor's patch.

Paolo