From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4oY-0004Q4-0X for qemu-devel@nongnu.org; Tue, 29 Jul 2014 06:39:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC4oR-0006Ee-Rp for qemu-devel@nongnu.org; Tue, 29 Jul 2014 06:39:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4oR-0006ET-Kf for qemu-devel@nongnu.org; Tue, 29 Jul 2014 06:39:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6TAdHZx003366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jul 2014 06:39:18 -0400 Message-ID: <53D779D1.6080701@redhat.com> Date: Tue, 29 Jul 2014 12:39:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1406561658-6761-1-git-send-email-pbonzini@redhat.com> <20140728212739.GA8453@redhat.com> <53D776B4.9090906@redhat.com> <20140729103150.GA13388@redhat.com> In-Reply-To: <20140729103150.GA13388@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Laszlo Ersek Cc: imammedo@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com Il 29/07/2014 12:31, Michael S. Tsirkin ha scritto: > > For patch "piix: set legacy table size for 1.7": didn't Igor say > > something that such a migration wouldn't work anyway? I could be > > remembering wrong. > > I don't recall this, but if there are more bug we could just > fix them too. You have to choose between a "-M pc-i440fx-1.7" that migrates from 1.7 to 2.1, and one that migrates from 2.0 to 2.1. - to make 1.7->2.1 work: you need both Igor's patch ("generate AML only...") and "piix: set legacy table size for 1.7". All configurations will work, including those with PCI bridges. - to make 2.0->2.1 work (with "-M pc-i440fx-1.7"): you need to omit "piix: set legacy table size for 1.7", and configurations with PCI bridges remain broken. Igor's patch is not needed, because it only affects configurations with PCI bridges. mst prefers the first one, and he changed my view on that too. And he noticed that with "piix: set legacy table size for 1.7" more things just work, so it's better to include it. Paolo