From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC6L5-0000PA-IB for qemu-devel@nongnu.org; Tue, 29 Jul 2014 08:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC6Ky-00039g-3m for qemu-devel@nongnu.org; Tue, 29 Jul 2014 08:17:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC6Kx-00039X-Sh for qemu-devel@nongnu.org; Tue, 29 Jul 2014 08:17:00 -0400 Message-ID: <53D790AE.4050907@redhat.com> Date: Tue, 29 Jul 2014 14:16:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140717110153.8352.80175.stgit@PASHA-ISP> <20140717110238.8352.38648.stgit@PASHA-ISP> <53D60E9D.2040000@redhat.com> <002501cfab25$2a4ca740$7ee5f5c0$@Dovgaluk@ispras.ru> In-Reply-To: <002501cfab25$2a4ca740$7ee5f5c0$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, fred.konrad@greensocs.com Il 29/07/2014 14:03, Pavel Dovgaluk ha scritto: >> > >> > This could be a subsection. sipi_vector is only used (needed) if wait_for_sipi != 0. > Right, sipi_vector is used when wait_for_sipi != 0. But we can set sipi_vector to non-zero, > save the snapshot, and then set wait_for_sipi. If that snapshot will be loaded, sipi_vector become incorrect. > Isn't this scenario possible? sipi_vector will not be used until CPU_INTERRUPT_SIPI is set, and then sipi_vector will have been overwritten with a new value. The architecture guarantees that. Paolo