From: Eric Blake <eblake@redhat.com>
To: Chunyan Liu <cyliu@suse.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info
Date: Tue, 29 Jul 2014 06:45:37 -0600 [thread overview]
Message-ID: <53D79771.1040006@redhat.com> (raw)
In-Reply-To: <1406618339-23513-1-git-send-email-cyliu@suse.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On 07/29/2014 01:18 AM, Chunyan Liu wrote:
> Add nocow info in 'qemu-img info' output to show whether the file
> currently has NOCOW flag set or not.
>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> Acked-by: Eric Blake <eblake@redhat.com>
Actually, this should be Reviewed-by, not Acked-by. My understanding is
that "Reviewed-by" is stronger (I actually read through the patch, and
looked for possible problems) while "Acked-by" is weaker (a maintainer
stating that the work is taken in on the basis of third-party reviews
without actually reviewing the patch itself).
> ---
> Resend for QEMU 2.2. Change json version comment.
>
> block/qapi.c | 25 +++++++++++++++++++++++++
> qapi/block-core.json | 5 ++++-
> 2 files changed, 29 insertions(+), 1 deletion(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-07-29 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 7:18 [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info Chunyan Liu
2014-07-29 12:45 ` Eric Blake [this message]
2014-07-30 2:57 ` Chun Yan Liu
-- strict thread matches above, loose matches on Subject: below --
2014-07-30 2:55 Chunyan Liu
2014-07-30 15:00 ` Stefan Hajnoczi
2014-11-21 16:25 ` Kevin Wolf
2014-11-21 16:29 ` Eric Blake
2014-11-24 3:11 ` Chun Yan Liu
2014-11-24 9:34 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D79771.1040006@redhat.com \
--to=eblake@redhat.com \
--cc=cyliu@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).