From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
andrey@xdel.ru, sviatoslav.pestov@gmail.com
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases
Date: Tue, 29 Jul 2014 09:11:11 -0600 [thread overview]
Message-ID: <53D7B98F.5070303@redhat.com> (raw)
In-Reply-To: <1406637686-25762-3-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 07/29/2014 06:41 AM, Stefan Hajnoczi wrote:
> This test case covers the basic bdrv_aio_multiwrite() scenarios:
> 1. Single request
> 2. Sequential requests
> 3. Overlapping requests
> 4. Disjoint requests
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> +echo
> +echo "== Overlapping requests =="
> +_make_test_img $size
> +$QEMU_IO -c "multiwrite 0 4k ; 1k 2k" "$TEST_IMG" | _filter_qemu_io
> +
This only tests superset overlap:
AAAA
BB
Wouldn't it be good to also test head overlap, tail overlap, and subset
overlap, as in:
AAA
BB
AAA
BB
AA
BBBB
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-07-29 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 12:41 [Qemu-devel] [PATCH 0/2] block: fix multiwrite_merge() overlapping requests Stefan Hajnoczi
2014-07-29 12:41 ` [Qemu-devel] [PATCH 1/2] block: fix overlapping multiwrite requests Stefan Hajnoczi
2014-07-29 12:46 ` Fam Zheng
2014-07-29 12:52 ` Stefan Hajnoczi
2014-07-29 12:41 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases Stefan Hajnoczi
2014-07-29 15:11 ` Eric Blake [this message]
2014-07-30 8:11 ` Stefan Hajnoczi
2014-07-31 18:19 ` Slava Pestov
2014-08-01 10:02 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7B98F.5070303@redhat.com \
--to=eblake@redhat.com \
--cc=andrey@xdel.ru \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sviatoslav.pestov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).