Re: [Qemu-devel] [PATCH RFC v2 07/12] VMState test: qmp interface for querying the vmstate testing process

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote:
> This patch provides the information about an already executing testing
> process. I have modified the qmp command to query-test-vmstates from
> test-vmstates-get-info.
> 
> Signed-off-by: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
> ---
>  qapi-schema.json | 34 ++++++++++++++++++++++++++++++++++
>  qmp-commands.hx  | 25 +++++++++++++++++++++++++
>  savevm.c         | 18 ++++++++++++++++++
>  3 files changed, 77 insertions(+)
> 

> +##
> +{ 'type': 'VMStateLogStateInfo',
> +  'data': { 'current-iteration': 'int',
> +            'iterations':        'int',
> +            'period':            'int' } }

Looks okay...


> +++ b/qmp-commands.hx

> +SQMP
> +query-test-vmstates-info
> +------------------------
> +
> +Get the parameters information
> +
> +- "current_iteration": the current iteration going on

s/_/-/

> +- "iterations:" the total number of assigned iterations
> +- "period": the sleep interval between the iteration
> +
> +Example:
> +
> +-> { "execute": "query-test-vmstates" }
> +<- { "return": {
> +            "current_iteration": 3,

...but spelling doesn't match the actual code.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]