From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Christopher Covington <cov@codeaurora.org>, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files
Date: Tue, 29 Jul 2014 09:25:12 -1000 [thread overview]
Message-ID: <53D7F518.4020603@twiddle.net> (raw)
In-Reply-To: <1406301817-20766-1-git-send-email-peter.maydell@linaro.org>
On 07/25/2014 05:23 AM, Peter Maydell wrote:
> + env->regs[15] = info->entry & 0xfffffffe;
You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99
does what you want. Which makes a tiny difference on a 64-bit host.
r~
next prev parent reply other threads:[~2014-07-29 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 15:23 [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files Peter Maydell
2014-07-25 16:09 ` Christopher Covington
2014-07-29 19:25 ` Richard Henderson [this message]
2014-07-29 19:31 ` Peter Maydell
2014-07-29 19:57 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7F518.4020603@twiddle.net \
--to=rth@twiddle.net \
--cc=cov@codeaurora.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).