From: John Snow <jsnow@redhat.com>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] libqos: Change free function called in malloc
Date: Tue, 29 Jul 2014 16:47:50 -0400 [thread overview]
Message-ID: <53D80876.2090608@redhat.com> (raw)
In-Reply-To: <1406226665-1710-6-git-send-email-marc.mari.barcelo@gmail.com>
On 07/24/2014 02:31 PM, Marc Marí wrote:
> Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
> ---
> tests/libqos/malloc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h
> index 46f6000..5565381 100644
> --- a/tests/libqos/malloc.h
> +++ b/tests/libqos/malloc.h
> @@ -32,7 +32,7 @@ static inline uint64_t guest_alloc(QGuestAllocator *allocator, size_t size)
>
> static inline void guest_free(QGuestAllocator *allocator, uint64_t addr)
> {
> - allocator->alloc(allocator, addr);
> + allocator->free(allocator, addr);
> }
>
> #endif
Imagine my surprise when I noticed the allocator was summoning up
millions of bytes. "Oh good!"
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2014-07-29 20:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 18:30 [Qemu-devel] [PATCH 0/7] Virtio PCI libqos driver Marc Marí
2014-07-24 18:30 ` [Qemu-devel] [PATCH 1/7] tests: Functions bus_foreach and device_find from libqos virtio API Marc Marí
2014-07-25 14:56 ` Stefan Hajnoczi
2014-07-24 18:31 ` [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization Marc Marí
2014-07-25 15:19 ` Stefan Hajnoczi
2014-07-25 17:01 ` Marc Marí
2014-07-28 9:21 ` Stefan Hajnoczi
2014-07-24 18:31 ` [Qemu-devel] [PATCH 3/7] libqtest: add QTEST_LOG for debugging qtest testcases Marc Marí
2014-07-25 15:22 ` Stefan Hajnoczi
2014-07-24 18:31 ` [Qemu-devel] [PATCH 4/7] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc Marc Marí
2014-07-25 15:22 ` Stefan Hajnoczi
2014-07-29 20:47 ` John Snow
2014-07-29 21:10 ` Peter Maydell
2014-07-24 18:31 ` [Qemu-devel] [PATCH 5/7] libqos: Change free function called in malloc Marc Marí
2014-07-25 15:23 ` Stefan Hajnoczi
2014-07-29 20:47 ` John Snow [this message]
2014-07-24 18:31 ` [Qemu-devel] [PATCH 6/7] virtio-blk: Correct bug in support for flexible descriptor layout Marc Marí
2014-07-24 18:31 ` [Qemu-devel] [PATCH 7/7] libqos: Added basic virtqueue support to virtio implementation Marc Marí
2014-07-25 16:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D80876.2090608@redhat.com \
--to=jsnow@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).