From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XCEJd-00028E-3s
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 16:48:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XCEJU-0004ws-MF
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 16:48:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XCEJU-0004wf-DT
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 16:48:00 -0400
Message-ID: <53D80876.2090608@redhat.com>
Date: Tue, 29 Jul 2014 16:47:50 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1406226665-1710-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1406226665-1710-6-git-send-email-marc.mari.barcelo@gmail.com>
In-Reply-To: <1406226665-1710-6-git-send-email-marc.mari.barcelo@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/7] libqos: Change free function called in
 malloc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= <marc.mari.barcelo@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>


On 07/24/2014 02:31 PM, Marc Mar=C3=AD wrote:
> Signed-off-by: Marc Mar=C3=AD <marc.mari.barcelo@gmail.com>
> ---
>   tests/libqos/malloc.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h
> index 46f6000..5565381 100644
> --- a/tests/libqos/malloc.h
> +++ b/tests/libqos/malloc.h
> @@ -32,7 +32,7 @@ static inline uint64_t guest_alloc(QGuestAllocator *a=
llocator, size_t size)
>  =20
>   static inline void guest_free(QGuestAllocator *allocator, uint64_t ad=
dr)
>   {
> -    allocator->alloc(allocator, addr);
> +    allocator->free(allocator, addr);
>   }
>  =20
>   #endif
Imagine my surprise when I noticed the allocator was summoning up=20
millions of bytes. "Oh good!"

Reviewed-by: John Snow <jsnow@redhat.com>