From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCQAB-0004RT-7R for qemu-devel@nongnu.org; Wed, 30 Jul 2014 05:27:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCQ9P-0004TC-Pv for qemu-devel@nongnu.org; Wed, 30 Jul 2014 05:26:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCQ9P-0004T2-Gb for qemu-devel@nongnu.org; Wed, 30 Jul 2014 05:26:23 -0400 Message-ID: <53D8BA35.4040100@redhat.com> Date: Wed, 30 Jul 2014 11:26:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140717110153.8352.80175.stgit@PASHA-ISP> <20140717110255.8352.73575.stgit@PASHA-ISP> <53D61AE3.6000700@redhat.com> <37740.9009532586$1406541296@news.gmane.org> <53D621F5.9050906@redhat.com> <000201cfabcf$a0568b40$e103a1c0$@Dovgaluk@ispras.ru> In-Reply-To: <000201cfabcf$a0568b40$e103a1c0$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, fred.konrad@greensocs.com Il 30/07/2014 10:24, Pavel Dovgaluk ha scritto: > Assertions is a good idea, we added such warning message to qemu_get_timedate function > to be sure, that it is used correctly with replay. > > Another thing, that could help for making snapshots - find a way to load replay structures > before all other ones. Are there any priorities in migration states list? No, it is just about vmstate registration order. In general bus parents come before bus children for obvious reasons. Paolo > Priorities could also solve some other issues, because sometimes post_load function > of one device uses other devices' functions. And the second ones could be not loaded yet.