From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVDX-00053p-GA for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCVDS-0002Qq-6f for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:50:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVDR-0002Oq-RP for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:50:54 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6UEoqWV030267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 10:50:52 -0400 Message-ID: <53D9064B.1070506@redhat.com> Date: Wed, 30 Jul 2014 08:50:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406311665-2814-1-git-send-email-mreitz@redhat.com> <1406311665-2814-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1406311665-2814-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kvaR6pMh8R6t33B0nTLQdfV702kIqhWg9" Subject: Re: [Qemu-devel] [PATCH 1/8] block: Add status callback to bdrv_amend_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kvaR6pMh8R6t33B0nTLQdfV702kIqhWg9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2014 12:07 PM, Max Reitz wrote: > Depending on the changed options and the image format, > bdrv_amend_options() may take a significant amount of time. In these > cases, a way to be informed about the operation's status is desirable. >=20 > Since the operation is rather complex and may fundamentally change the > image, implementing it as AIO or a couroutine does not seem feasible. O= n > the other hand, implementing it as a block job would be significantly > more difficult than a simple callback and would not add benefits other > than progress report to the amending operation, because it should not > actually be run as a block job at all. >=20 > A callback may not be very pretty, but it's very easy to implement and > perfectly fits its purpose here. Agree with this reasoning. >=20 > Signed-off-by: Max Reitz > --- > block.c | 5 +++-- > block/qcow2.c | 5 ++++- > include/block/block.h | 5 ++++- > include/block/block_int.h | 3 ++- > qemu-img.c | 2 +- > 5 files changed, 14 insertions(+), 6 deletions(-) Good for 2.2, and looks like this patch is the same in both your original and alternate series. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kvaR6pMh8R6t33B0nTLQdfV702kIqhWg9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2QZLAAoJEKeha0olJ0NqcjoH+wY8enI2NdgGyStmEYVoqPN/ DdoDKgOuvE5wdCsDvUcbWhBxL2N6ris+/ccmh3BuRVVoL0uMb1dim+z5I2Y88qD4 KN8auf8A/8TOX3cxP9uUuNuZ5Fev5Gl5xEqXZjd5l+O5s1RjZR1zXefkIrV0CCAf P3/lGOPMkPKBaZXFEK1h9mkE7pDelWIvznyT42gMGGiJIGuCHQBEY++7DFKf5ebZ +OGpFwasEYdXf6iPOQrsWgrOiE049VFhf0RBxemQMMDJD20mJVnmiUSaU2oc+yNw Rexqo6p+XZ+vRsmuouESjkqThBGfektX4vKG3zR0PY+xsiPyFv7MUmV3kVSAA9Q= =Kzbw -----END PGP SIGNATURE----- --kvaR6pMh8R6t33B0nTLQdfV702kIqhWg9--