From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVDl-0005Kd-31 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCVDe-0002eq-UT for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:51:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVDe-0002eU-NL for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:51:06 -0400 Message-ID: <53D9064C.6090505@redhat.com> Date: Wed, 30 Jul 2014 16:50:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1406720388-18671-1-git-send-email-ming.lei@canonical.com> <1406720388-18671-9-git-send-email-ming.lei@canonical.com> <53D8F85A.1090400@redhat.com> <20140730144057.GB26933@redhat.com> In-Reply-To: <20140730144057.GB26933@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/15] virtio: decrease size of VirtQueueElement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Peter Maydell , Fam Zheng , Ming Lei , qemu-devel@nongnu.org, Stefan Hajnoczi Il 30/07/2014 16:40, Michael S. Tsirkin ha scritto: > As long as you relying on this, why not allocate in_sg/out_sg > separately? Because allocations can be expensive. > In any case, a bunch of code needs to be audited to make sure > no one assumes we can always stick VIRTQUEUE_MAX_SIZE there. > > But what really worries me is this is an optimization patch > without any numbers accompanying it. I agree. > I would say split this out from your virtio blk work, > work on this separately. This, too. Paolo