From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVIv-0002Bs-Nd for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:56:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCVIp-0002Ba-84 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:56:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVIo-00028I-S4 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:56:27 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6UEuQQ1032339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 10:56:26 -0400 Message-ID: <53D90799.4070406@redhat.com> Date: Wed, 30 Jul 2014 08:56:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406311665-2814-1-git-send-email-mreitz@redhat.com> <1406311665-2814-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1406311665-2814-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C08lkpcEbe5NJ5w3O0XH7prtDGffRnVQd" Subject: Re: [Qemu-devel] [PATCH 3/8] qemu-img: Fix insignifcant memleak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C08lkpcEbe5NJ5w3O0XH7prtDGffRnVQd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2014 12:07 PM, Max Reitz wrote: > As soon as options is set in img_amend(), it needs to be freed before > the function returns. This leak is rather insignifcant, as qemu-img wil= l > exit subsequently anyway, but there's no point in not fixing it. >=20 > Signed-off-by: Max Reitz > --- > qemu-img.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --C08lkpcEbe5NJ5w3O0XH7prtDGffRnVQd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2QeZAAoJEKeha0olJ0Nq4BMH/0K5gTa+L8Y6sYEJpNhHRviG T3WKGdDjRVeKhz+9L2zBz53rTYgq+csLShMwm00GGceFncc/K4LrJEN8iQNHbpiQ z7qUdDbipnfinZXhIlHVfk8/cIDR1S22HAQd+KyFpOWhBjK4lZdTi6r41YCNEP2V 0fHn5X3yC37kpZbBP4KJcP4KZBwlI7IEvMkAyql1PN9PDDlPb5d4TqW6YVCCEiNU FvNQDGWh4QShABllzgkQ0w2fcGFktzC9Tm5brIW+2ZKEU1FXlXln9/VSMCkkTvFa oGvwDKTRlSjKdX16eUFp7++hu/Yjl6IRzTZNIEEGzDT7RazmApBEFtipk8WrF2Q= =8XQY -----END PGP SIGNATURE----- --C08lkpcEbe5NJ5w3O0XH7prtDGffRnVQd--