From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVKx-0004aJ-Dq for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:58:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCVKs-0005D1-7q for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:58:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVKr-0005BY-U5 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 10:58:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6UEwXsG027391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 10:58:33 -0400 Message-ID: <53D90818.4010901@redhat.com> Date: Wed, 30 Jul 2014 08:58:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406402531-9278-1-git-send-email-mreitz@redhat.com> <1406402531-9278-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1406402531-9278-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WBQ73QN6a5TCsnvS3X6G4wJ4aunruEulr" Subject: Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WBQ73QN6a5TCsnvS3X6G4wJ4aunruEulr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2014 01:22 PM, Max Reitz wrote: > As soon as options is set in img_amend(), it needs to be freed before > the function returns. This leak is rather insignifcant, as qemu-img wil= l s/insignifcant/insignificant/ > exit subsequently anyway, but there's no point in not fixing it. >=20 > Signed-off-by: Max Reitz > --- > qemu-img.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) 1-3 look the same as in the other version of this series, so no further comments on them. I'll try and review both series to see if either one makes more sense as being more desirable. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WBQ73QN6a5TCsnvS3X6G4wJ4aunruEulr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2QgYAAoJEKeha0olJ0NqU4gIAIQlGfBff/hD8tC3uQv6C4K0 jwJ8ruxJCjG1W/D4RlIR4qBWJPNmiWwsr7/7ax31M2byxdHJ50+siBVcI73XyXVe tR9UrplHyFIUSjA3EfORSnHOFKXp/voA6HpLdTbTIpncUTx2IZvCNhk8t6co7OaI dde7/sxM915cQVjlHh/wEej/GBgU06B+W7J2c5TYTC7ic+/2qDuiOLb9kGTEC3S/ bR+xX1v/hPkLC2lPc9kQ98vV6nMmVOXQIwSAlZB4bisQjPvkCyLi6OMM78SfKLIe ptA+Gy/WQZSCiD0gGItOPLFpxsTB8KaJFwFwmSFeIothQc/bYzYPHWwdXzvzPa4= =C/6W -----END PGP SIGNATURE----- --WBQ73QN6a5TCsnvS3X6G4wJ4aunruEulr--