Re: [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

On 07/25/2014 12:07 PM, Max Reitz wrote:
> The only really time-consuming operation potentially performed by
> qcow2_amend_options() is zero cluster expansion when downgrading qcow2
> images from compat=1.1 to compat=0.10, so report status of that
> operation and that operation only through the status CB.
> 
> For this, count the number of L2 zero entries, use this as the basis for
> the total "amend job length" and increase the current offset by the
> cluster size multiplied by the refcount of the L2 table when expanding
> zero clusters.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/qcow2-cluster.c | 145 ++++++++++++++++++++++++++++++++++++++++++++++++--
>  block/qcow2.c         |   9 ++--
>  block/qcow2.h         |   3 +-
>  3 files changed, 147 insertions(+), 10 deletions(-)
> 

Makes sense, although I'll defer R-b until I've looked at both competing
series in entirety.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]