From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVjW-0007JQ-Kr for qemu-devel@nongnu.org; Wed, 30 Jul 2014 11:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCVjQ-0003Ol-0V for qemu-devel@nongnu.org; Wed, 30 Jul 2014 11:24:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCVjP-0003OV-Mh for qemu-devel@nongnu.org; Wed, 30 Jul 2014 11:23:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6UFNsUf013921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 11:23:54 -0400 Message-ID: <53D90E09.70103@redhat.com> Date: Wed, 30 Jul 2014 09:23:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406311665-2814-1-git-send-email-mreitz@redhat.com> <1406311665-2814-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1406311665-2814-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TWgTI7Nfk7ni6sTT42t1v7iEMQ2mnANOu" Subject: Re: [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TWgTI7Nfk7ni6sTT42t1v7iEMQ2mnANOu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2014 12:07 PM, Max Reitz wrote: > The only really time-consuming operation potentially performed by > qcow2_amend_options() is zero cluster expansion when downgrading qcow2 > images from compat=3D1.1 to compat=3D0.10, so report status of that > operation and that operation only through the status CB. >=20 > For this, count the number of L2 zero entries, use this as the basis fo= r > the total "amend job length" and increase the current offset by the > cluster size multiplied by the refcount of the L2 table when expanding > zero clusters. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 145 ++++++++++++++++++++++++++++++++++++++++++= ++++++-- > block/qcow2.c | 9 ++-- > block/qcow2.h | 3 +- > 3 files changed, 147 insertions(+), 10 deletions(-) >=20 Makes sense, although I'll defer R-b until I've looked at both competing series in entirety. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TWgTI7Nfk7ni6sTT42t1v7iEMQ2mnANOu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2Q4JAAoJEKeha0olJ0NqxMAH/0/NqYu4MXjOTYxhqGeuQyoX ottGNHUJmZcsf1OMNd9L8/j1R8Orb29BBrHxNc7tZNJyzzsX32krx5xwhahuwIpE 08edjde75WZoZPqU7Zkd+6UrXfgFrap3cwabiARdns0BIpUJ9z3ploS3ef0u7bBL rCDa1uDAk6fvOqzj4OhgFhj4sCPAqrFYvt7//fdbikDKEAIhFSNuzv9LOKiykzQD MmjZPO7eRkCwUe/FlxtUeSSQjdRXbO6vddeDSTx2HfZQQo4p4ADhGT/S1HTH94JK 8dGAVRBGRDe5dJuQ6Gsmmh01MdLafX0YYs4ZfQ/KQrdxGOYqO9XnTwDrHzyW6r4= =y0d5 -----END PGP SIGNATURE----- --TWgTI7Nfk7ni6sTT42t1v7iEMQ2mnANOu--