From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1XCWZy-0005Uz-SC
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 12:18:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1XCWZs-0007zw-5Q
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 12:18:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58415)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1XCWZr-0007zY-Up
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 12:18:08 -0400
Message-ID: <53D91ABA.1060804@redhat.com>
Date: Wed, 30 Jul 2014 18:18:02 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1406631139-6754-1-git-send-email-stefanb@us.ibm.com>
	<20140730132027.GA26025@redhat.com> <53D902F6.1050106@redhat.com>
	<OFF408D4D7.28C3B5C4-ON85257D25.0052F651-85257D25.0053590C@us.ibm.com>
	<20140730152040.GE26313@redhat.com>
	<OF59AE04E8.E871644B-ON85257D25.00548366-85257D25.005519AB@us.ibm.com>
	<53D91216.1030800@redhat.com>
	<OF1A818C1E.C8B1BC10-ON85257D25.00565F45-85257D25.005679AC@us.ibm.com>
	<53D9163C.6000304@redhat.com>
	<OF7E385550.C8D02D32-ON85257D25.00581056-85257D25.00583ACB@us.ibm.com>
	<20140730161033.GF27451@redhat.com>
In-Reply-To: <20140730161033.GF27451@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Stefan Berger <stefanb@us.ibm.com>
Cc: qemu-devel@nongnu.org, Stefan Berger <stefanb@linux.vnet.ibm.com>

On 07/30/14 18:10, Michael S. Tsirkin wrote:
> On Wed, Jul 30, 2014 at 12:03:46PM -0400, Stefan Berger wrote:
>> Laszlo Ersek <lersek@redhat.com> wrote on 07/30/2014 11:58:52 AM:

>>> In the short term, probably skip TCPA, or advise users in documentation
>>> not to enable the TPM device when running OVMF.
> 
> Hmm but doesn't OVMF rely on all tables being packed without holes
> in memory?
> I remember it did, and if it still does, this breaks unless TCPA is
> the last ...

Ah, do you mean that the table size field in the ACPI table header of
TCPA would *not* include the TCG event log that is tacked-on? Yes, that
would certainly trip up the parser. It advances by looking at the table
size fields in the headers.

>> I guess we can do that. You can skip the TCPA for now; once the UEFI has TPM
>> support, this table would then  be needed.

> If it doesn't work anyway, we can just tell people not to enable TPM
> with OVMF. No need for hack in OVMF to skip it.

Agree 100%.

Thanks
Laszlo