From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak
Date: Wed, 30 Jul 2014 22:08:11 +0200 [thread overview]
Message-ID: <53D950AB.7070409@redhat.com> (raw)
In-Reply-To: <53D90818.4010901@redhat.com>
On 30.07.2014 16:58, Eric Blake wrote:
> On 07/26/2014 01:22 PM, Max Reitz wrote:
>> As soon as options is set in img_amend(), it needs to be freed before
>> the function returns. This leak is rather insignifcant, as qemu-img will
> s/insignifcant/insignificant/
I wonder how I was able to get it wrong the same way twice...
>> exit subsequently anyway, but there's no point in not fixing it.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> qemu-img.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> 1-3 look the same as in the other version of this series, so no further
> comments on them. I'll try and review both series to see if either one
> makes more sense as being more desirable.
Thank you,
Max
next prev parent reply other threads:[~2014-07-30 20:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 19:22 [Qemu-devel] [PATCH alt 0/7] block/qcow2: Improve zero cluster expansion Max Reitz
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 1/7] block: Add status callback to bdrv_amend_options() Max Reitz
2014-07-31 7:51 ` Benoît Canet
2014-07-31 8:07 ` Benoît Canet
2014-08-01 20:06 ` Max Reitz
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 2/7] qemu-img: Add progress output for amend Max Reitz
2014-07-31 7:56 ` Benoît Canet
2014-08-01 20:09 ` Max Reitz
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak Max Reitz
2014-07-30 14:58 ` Eric Blake
2014-07-30 20:08 ` Max Reitz [this message]
2014-07-31 7:59 ` Benoît Canet
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 4/7] block/qcow2: Implement status CB for amend Max Reitz
2014-07-30 16:28 ` Eric Blake
2014-07-31 8:06 ` Benoît Canet
2014-08-01 20:18 ` Max Reitz
2014-08-01 20:38 ` Eric Blake
2014-08-01 20:48 ` Max Reitz
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 5/7] block/qcow2: Make get_refcount() global Max Reitz
2014-07-31 8:09 ` Benoît Canet
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 6/7] block/qcow2: Simplify shared L2 handling in amend Max Reitz
2014-07-31 8:24 ` Benoît Canet
2014-08-01 20:51 ` Max Reitz
2014-07-26 19:22 ` [Qemu-devel] [PATCH alt 7/7] iotests: Expand test 061 Max Reitz
2014-07-31 8:30 ` Benoît Canet
2014-08-01 20:34 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D950AB.7070409@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).