From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCaMJ-0002Ls-Qp for qemu-devel@nongnu.org; Wed, 30 Jul 2014 16:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCaMB-0008Na-3Z for qemu-devel@nongnu.org; Wed, 30 Jul 2014 16:20:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCaMA-0008Lq-S0 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 16:20:15 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6UKKCHx015898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 16:20:13 -0400 Message-ID: <53D95378.6070206@redhat.com> Date: Wed, 30 Jul 2014 22:20:08 +0200 From: Max Reitz MIME-Version: 1.0 References: <1406311665-2814-1-git-send-email-mreitz@redhat.com> <1406311665-2814-3-git-send-email-mreitz@redhat.com> <53D90773.6020708@redhat.com> In-Reply-To: <53D90773.6020708@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/8] qemu-img: Add progress output for amend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 30.07.2014 16:55, Eric Blake wrote: > On 07/25/2014 12:07 PM, Max Reitz wrote: >> Now that bdrv_amend_options() supports a status callback, use it to >> display a progress report. >> >> Signed-off-by: Max Reitz >> --- >> qemu-img.c | 26 +++++++++++++++++++++++--- >> 1 file changed, 23 insertions(+), 3 deletions(-) > No documentation of the new option? The code looks fine, but the texi > needs to mention -p before I can give R-b Oops, I completely forgot. I'll fix it. Max