From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCr62-00036X-Ah for qemu-devel@nongnu.org; Thu, 31 Jul 2014 10:12:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCr5w-0006X1-7r for qemu-devel@nongnu.org; Thu, 31 Jul 2014 10:12:42 -0400 Message-ID: <53DA4ED1.2020002@suse.de> Date: Thu, 31 Jul 2014 16:12:33 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1404324093-19225-1-git-send-email-agraf@suse.de> <1404324093-19225-2-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/9] qom: Move property helpers to own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , Eric Auger , "qemu-devel@nongnu.org Developers" , qemu-ppc Mailing List , "Stalley, Sean" , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 31.07.14 15:46, Peter Crosthwaite wrote: > On Thu, Jul 3, 2014 at 4:01 AM, Alexander Graf wrote: >> We have accumulated a number of friendly helpers that make registration >> of properties easier. However, their number is only increasing and they >> start to clutter the core object.c file. >> >> So let's move them into a separate C file and thus ensure that we have >> room to grow :). >> >> Signed-off-by: Alexander Graf >> --- >> backends/hostmem-file.c | 1 + >> backends/hostmem.c | 1 + >> backends/rng-egd.c | 1 + >> backends/rng-random.c | 1 + >> backends/rng.c | 1 + >> backends/tpm.c | 1 + >> hw/acpi/ich9.c | 1 + >> hw/acpi/pcihp.c | 1 + >> hw/acpi/piix4.c | 1 + >> hw/core/machine.c | 1 + >> hw/core/qdev.c | 1 + >> hw/i386/acpi-build.c | 1 + >> hw/isa/lpc_ich9.c | 1 + >> hw/ppc/spapr.c | 1 + >> include/qom/object.h | 85 ------------------- >> include/qom/property.h | 104 ++++++++++++++++++++++++ >> memory.c | 1 + >> qom/Makefile.objs | 2 +- >> qom/object.c | 197 ++------------------------------------------ >> qom/property.c | 212 ++++++++++++++++++++++++++++++++++++++++++++++++ >> target-i386/cpu.c | 1 + >> ui/console.c | 1 + >> 22 files changed, 340 insertions(+), 277 deletions(-) >> create mode 100644 include/qom/property.h >> create mode 100644 qom/property.c >> >> - * object_property_add_uint64_ptr: >> - * @obj: the object to add a property to >> - * @name: the name of the property >> - * @v: pointer to value >> - * @errp: if an error occurs, a pointer to an area to store the error >> - * >> - * Add an integer property in memory. This function will add a >> - * property of type 'uint64'. >> - */ >> -void object_property_add_uint64_ptr(Object *obj, const char *name, >> - const uint64_t *v, Error **Errp); >> - >> -/** >> * object_property_add_alias: > Any reason to not migrate alias and link props as well? IIRC I tried, but there were more interdependencies inside the same file. So I went with the easy ones (that I cared about) first and left the rest as exercise for the reader :). Alex