From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru,
"maria.klimushenkova@ispras.ru" <maria.klimushenkova@ispras.ru>,
afaerber@suse.de, fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate
Date: Thu, 31 Jul 2014 18:20:00 +0200 [thread overview]
Message-ID: <53DA6CB0.3060109@redhat.com> (raw)
In-Reply-To: <3p4rhou9g4v7a9ufvf2ed5wo.1406821520941@email.android.com>
Il 31/07/2014 17:49, Pavel Dovgalyuk ha scritto:
> We cannot calculate timers in post_load, because it requires correct
> value of virtual clock. And at that moment replay data structures could
> be not loaded yet.
Then this patch (and similarly others in this early part of the series)
should be properly named "work around deficiencies of replay", not "add
new fields to vmstate".
Replay of course has to do _more_ things than migration. However,
anything that makes replay _different_ from migration, for things that
migration already does, is not going to fly. It means instant bitrot,
and will not be accepted without very good justification.
timers_state is serialized before everything else for a reason. If you
need to serialize more state for replay to work, add it to a subsection
of timers_state that is only included during record.
Paolo
next prev parent reply other threads:[~2014-07-31 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 15:49 [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate Pavel Dovgalyuk
2014-07-31 15:55 ` Eric Blake
2014-07-31 16:20 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-31 12:53 [Qemu-devel] [RFC PATCH v3 00/49] Deterministic replay and reverse execution Pavel Dovgalyuk
2014-07-31 12:54 ` [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate Pavel Dovgalyuk
2014-07-31 14:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DA6CB0.3060109@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=batuzovk@ispras.ru \
--cc=fred.konrad@greensocs.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).