From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCt5W-0002So-3z for qemu-devel@nongnu.org; Thu, 31 Jul 2014 12:20:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCt5N-0001iT-2i for qemu-devel@nongnu.org; Thu, 31 Jul 2014 12:20:18 -0400 Received: from mail-qg0-x22f.google.com ([2607:f8b0:400d:c04::22f]:35511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCt5M-0001iO-VG for qemu-devel@nongnu.org; Thu, 31 Jul 2014 12:20:09 -0400 Received: by mail-qg0-f47.google.com with SMTP id i50so4286264qgf.6 for ; Thu, 31 Jul 2014 09:20:08 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53DA6CB0.3060109@redhat.com> Date: Thu, 31 Jul 2014 18:20:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <3p4rhou9g4v7a9ufvf2ed5wo.1406821520941@email.android.com> In-Reply-To: <3p4rhou9g4v7a9ufvf2ed5wo.1406821520941@email.android.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, "maria.klimushenkova@ispras.ru" , afaerber@suse.de, fred.konrad@greensocs.com Il 31/07/2014 17:49, Pavel Dovgalyuk ha scritto: > We cannot calculate timers in post_load, because it requires correct > value of virtual clock. And at that moment replay data structures could > be not loaded yet. Then this patch (and similarly others in this early part of the series) should be properly named "work around deficiencies of replay", not "add new fields to vmstate". Replay of course has to do _more_ things than migration. However, anything that makes replay _different_ from migration, for things that migration already does, is not going to fly. It means instant bitrot, and will not be accepted without very good justification. timers_state is serialized before everything else for a reason. If you need to serialize more state for replay to work, add it to a subsection of timers_state that is only included during record. Paolo