From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XCzqZ-0004f8-6z
	for qemu-devel@nongnu.org; Thu, 31 Jul 2014 19:33:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XCzqQ-0000a6-Q0
	for qemu-devel@nongnu.org; Thu, 31 Jul 2014 19:33:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60375)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XCzqQ-0000ZU-IB
	for qemu-devel@nongnu.org; Thu, 31 Jul 2014 19:33:10 -0400
Message-ID: <53DAD22A.201@redhat.com>
Date: Thu, 31 Jul 2014 19:32:58 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1404757089-4836-1-git-send-email-jsnow@redhat.com>
	<1404757089-4836-16-git-send-email-jsnow@redhat.com>
	<20140731122336.GR25929@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140731122336.GR25929@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pbonzini@redhat.com
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com


On 07/31/2014 08:23 AM, Stefan Hajnoczi wrote:
> On Mon, Jul 07, 2014 at 02:17:56PM -0400, John Snow wrote:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> This will provide a hook for sending the result of the command via the
>> FIS receive area.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>>   hw/ide/core.c | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/ide/core.c b/hw/ide/core.c
>> index bd3bd34..d900ba0 100644
>> --- a/hw/ide/core.c
>> +++ b/hw/ide/core.c
>> @@ -422,6 +422,9 @@ static inline void ide_abort_command(IDEState *s)
>>   {
>>       s->status = READY_STAT | ERR_STAT;
>>       s->error = ABRT_ERR;
>> +    if (s->end_transfer_func != ide_transfer_stop) {
>> +        ide_transfer_stop(s);
>> +    }
>>   }
> I don't understand this.
>
> ide_transfer_stop() sets s->send_transfer_func = ide_transfer_stop.
> This has the side-effect of making ide_is_pio_out() return true (not
> sure if that poses a problem).
>
> Why can't we call ide_transfer_stop() when s->end_transfer_func ==
> ide_transfer_stop?
>
> Stefan
I'm afraid I need to defer to your judgment on this one, Paolo.