From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD2x1-0000Ui-CH for qemu-devel@nongnu.org; Thu, 31 Jul 2014 22:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XD2ww-0001Hn-Tq for qemu-devel@nongnu.org; Thu, 31 Jul 2014 22:52:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD2ww-0001HO-Ld for qemu-devel@nongnu.org; Thu, 31 Jul 2014 22:52:06 -0400 Message-ID: <53DB00AE.8050001@redhat.com> Date: Thu, 31 Jul 2014 20:51:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406860365-5516-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1406860365-5516-1-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IUawNPotD316N61foiDH1RtjmjTlV5hKu" Subject: Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, weidong.huang@huawei.com, stefanha@redhat.com, mst@redhat.com, marcel.a@redhat.com, luonengjun@huawei.com, armbru@redhat.com, lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com, aliguori@amazon.com, imammedo@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, afaerber@suse.de, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IUawNPotD316N61foiDH1RtjmjTlV5hKu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2014 08:32 PM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > $WHATEVER: don't use 'Yoda conditions' >=20 > 'Yoda conditions' are not part of idiomatic QEMU coding > style, so rewrite them in the more usual order. >=20 > v2: > - add more specific commit messages suggested by PMM, thanks. > - introduce section of conditional statement to CODING_STYLE. >=20 >=20 > Gonglei (8): > CODING_STYLE: Section about conditional statement > usb: a trivial code change for more idiomatic writing style You didn't rename the subject lines. I think the request you were given on v1 was to name this patch: usb: don't use 'Yoda conditions' > audio: a trivial code change for more idiomatic writing style audio: don't use 'Yoda conditions' > isa-bus: a trivial code change for more idiomatic writing style > a trivial code change for more idiomatic writing style > spice: a trivial code change for more idiomatic writing style > vl: a trivial code change for more idiomatic writing style > vmxnet3: a trivial code change for more idiomatic writing style and so on --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IUawNPotD316N61foiDH1RtjmjTlV5hKu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2wCuAAoJEKeha0olJ0NqKwwH/Rp/vgrjGLRSYUF74lJCfhTj Mjl1WZPmM7dcfug9aquGUS9s7aZkmK/3J50yrOj7GM3ZBUz89KZf2+5ytWklO/yk uNuarut0ZLFYJM0Gyf+hTs42mez/OyZiYVE3rab3F8LBUXVNIhaInLMX6+Ws0d8Q wXmTzFgYJTYXteVUIq6jJuiGQKZeyTxLJE7ksZF9fS4mi2iVV/oIueoYg0etA7YH MZS9Zs4kI+RQGZhKJrpkL4uWNa7OYjfiUyd3oQUIQfWDVUpqSMfPigw8B6YTrquN vWHiONNnpj77yWjxI4PUzK4cVoSJvL60s8VhffxzPdIjal66aKc2R5lB+Fmihpc= =p7kY -----END PGP SIGNATURE----- --IUawNPotD316N61foiDH1RtjmjTlV5hKu--