From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
weidong.huang@huawei.com, stefanha@redhat.com, mst@redhat.com,
marcel.a@redhat.com, luonengjun@huawei.com, armbru@redhat.com,
lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com,
aliguori@amazon.com, imammedo@redhat.com, dmitry@daynix.com,
pbonzini@redhat.com, peter.huangpeng@huawei.com,
afaerber@suse.de, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style
Date: Thu, 31 Jul 2014 21:08:09 -0600 [thread overview]
Message-ID: <53DB0499.2010505@redhat.com> (raw)
In-Reply-To: <1406860365-5516-3-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On 07/31/2014 08:32 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/usb/dev-audio.c | 2 +-
> hw/usb/dev-mtp.c | 4 ++--
> hw/usb/hcd-ehci.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
> index bfebfe9..988f6cc 100644
> --- a/hw/usb/dev-audio.c
> +++ b/hw/usb/dev-audio.c
> @@ -371,7 +371,7 @@ static void output_callback(void *opaque, int avail)
> return;
> }
> data = streambuf_get(&s->out.buf);
> - if (NULL == data) {
> + if (data == NULL) {
Wouldn't it be even more idiomatic as:
if (!data) {
Probably applies throughout your series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-01 3:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 2:32 [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions arei.gonglei
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement arei.gonglei
2014-08-01 3:07 ` Eric Blake
2014-08-01 3:31 ` Gonglei (Arei)
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style arei.gonglei
2014-08-01 3:08 ` Eric Blake [this message]
2014-08-01 3:32 ` Gonglei (Arei)
2014-08-01 3:42 ` Andreas Färber
2014-08-01 3:54 ` Gonglei (Arei)
2014-08-01 6:41 ` Markus Armbruster
2014-08-01 6:50 ` Gonglei (Arei)
2014-08-01 15:56 ` Eric Blake
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 3/8] audio: " arei.gonglei
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 4/8] isa-bus: " arei.gonglei
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 5/8] " arei.gonglei
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 6/8] spice: " arei.gonglei
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 7/8] vl: " arei.gonglei
2014-08-01 2:32 ` [Qemu-devel] [PATCH v2 8/8] vmxnet3: " arei.gonglei
2014-08-01 2:51 ` [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions Eric Blake
2014-08-01 3:23 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB0499.2010505@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=av1474@comtv.ru \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).